Re: [Opensync-devel] patches 2

[Chris F. <cd...@fo...>]

On Wed, Aug 07, 2013 at 12:44:23PM +0100, Mark Ellis wrote:
> 1-glibdep-threads.diff
> Glib changed some threading functions in 2.32 and deprecated the old
> versions, I've written this to build with both styles depending on the
> version, since 2.32 didn't feel that old.

Committed.  Thanks!


> 3-glibdep-basename.diff
> g_basename() was deprecated ages ago.

Committed, thanks!


> 2-glibdep-get-time.diff
> g_source_get_current_time() was deprecated in glib 2.28, which seems old
> enough to me to not worry about, so I've bumped the required version to
> 2.28 and rewritten with g_source_get_time()

I didn't apply this patch, but wrote a slightly different one, wrapping
the API change in a static function.  The reason I did this was because
glib 2.24 is still used in Ubuntu's oldest LTS release, which is still
out there.  Plus my old Debian system uses 2.24 :-)  I also bumped
the min in CMakeLists.txt to 2.24 instead of your 2.28.

A few more patches to go, yet.

Thanks again!
- Chris