Re: [Opensync-devel] [Fwd: patches 1]

[Chris F. <cd...@fo...>]

On Wed, Aug 07, 2013, Mark Ellis wrote:
> 1-glibdep-threads.diff
> Glib changed some threading functions in 2.32 and deprecated the old
> versions, I've written this to build with both styles depending on the
> version, since 2.32 didn't feel that old.

Thanks Mark for these patches!  I'll putter through them as I have
time.  Hopefully it won't take too long to get them into the main tree.

As I was reading through this patch, and looking at the API change,
I started wondering, wouldn't it be better if we wrapped glib's API
in our own?  Somehow, I like the idea of pointers which are filled,
and freed, rather than keeping the entire sturcture around.
Pointers are opaque, and we don't need the structure
definition to work with them.

So with that in mind, I'm not sure why glib decided to change the
way they did, but regardless, we don't have to follow in their footsteps,
and we can write our own pointer-oriented API.  It might even be
cleaner in the long run.

Compare to this patch:
http://lists.freedesktop.org/archives/gstreamer-commits/2012-March/061105.html

What do you think?  Are there any drawbacks to writing our own?

Thanks,
- Chris