Re: [Opensync-devel] [PATCH] Small memoryleak fixed in serializer.c

[Chris F. <cd...@fo...>]

On Fri, Jul 15, 2011 at 02:15:21AM -0300, Luiz Angelo Daros de Luca wrote:
> Hello,
> 
> While playing with valgrind, I found some small memory leaks.
> I fixed what it found in serializer.c and another one that it did not
> found. My code is in:
> 
> git://github.com/luizluca/opensync-luizluca.git   fix-memoryleak-serializer

Thanks, I've merged that.


> The first do some formatting cleanup (kdeveloper help) and the other
> ones are the real fixes.
> 
> BTW, there is more memory leaks in code. I just didn't stopped to fix them.

Yeah, I've been breaking open the valgrind as well.  There's quite a
bit to fix.  Also, my commit 2e54e5125aee9d0a4d8479c1276b7cc49db82677
doesn't quite fix the issue entirely.  If you find you encounter crashes
during sync, just revert that commit in your repo until I find the
official fix.  It is slow going, following the logic through client
proxy, client, and the message queue. :-)

- Chris