Re: [Opensync-devel] Patch for evolution plugin

[Nicolas <pr...@fr...>]

Le samedi 02 juillet 2011 à 12:27 +0200, Daniel Gollub a écrit :
> Hi Nicolas,
> 
> On Saturday, July 02, 2011 08:06:40 am Nicolas wrote:
> > With this patch, it works with new Evolution release 2.32 and higher.
> 
> Could you explain which change was exactly required to get it working again for 2.32? It's hard 
> for me to distinguish the diff between the new feature and the required change to make it work.

It's an old patch ; that I have forgotten to send you.

It's the API that is different with 2.32 :

In src/evolution2_sync.c:

  -           osync_trace(TRACE_INTERNAL, "Comparing source name %s and
%s", e_source_peek_name(source), uri);
  -           if (!strcmp(e_source_peek_name(source), uri))
  +           osync_trace(TRACE_INTERNAL, "Comparing source name %s and
%s", e_source_peek_name(source), book);
  +           if (!strcmp(e_source_peek_name(source), book))


My modification works with old Evolution release. But to check !

With this modification, opensync can find the good address book ;
otherwise it finds nothing.

 
> > Moreover, I have added an option to be able to choose the evolution
> > addressbook, calendar, tasks or memo  to sync.
> [...]
> 
> Nice!
> 
> One more question:
> 
> ---8<--
> @@ -88,7 +90,7 @@
>          osync_trace(TRACE_ENTRY, "%s(%p, %p, %p, %p)", __func__, sink, info, ctx, userdata);
>   	OSyncEvoCalendar * evo_cal = (OSyncEvoCalendar *)userdata;
>  
> -	if (!(evo_cal->calendar = evo2_ecal_open_cal(evo_cal->uri, evo_cal->source_type, &error))) {
> +	if (!(evo_cal->calendar = evo2_ecal_open_cal(evo_cal->uri, "Personnel", evo_cal->source_type, 
> &error))) {
>  		goto error;
>  	}
> ---8<---
> 
> In this diff hunk you set "Personnel" - is this hardcoded string intended at this place?

Sorry an error...

Should be as for address book.

> 
> > 
> > <Name>....</Name> : it's to select the good entry in evolution.
> > 
> > (idem for calendar, memo and tasks)
> 
> Do you know if the <Name/> value is language dependent in evoulation?
> If so, do you know any language indepenent good default value?
> You wrote in the default configuration "Personnal" in the plugin-code "Personnel".

Yes, it depends on the evolution language.

So, I hardcoded in the default configuration the english name.

We can add comments into the default file.

> Best Regards,
> Daniel

Regards,

Nicolas