Re: [Opensync-devel] Patch for evolution plugin

[Daniel G. <go...@b1...>]

Hi Nicolas,

On Saturday, July 02, 2011 08:06:40 am Nicolas wrote:
> With this patch, it works with new Evolution release 2.32 and higher.

Could you explain which change was exactly required to get it working again for 2.32? It's hard 
for me to distinguish the diff between the new feature and the required change to make it work.

> 
> Moreover, I have added an option to be able to choose the evolution
> addressbook, calendar, tasks or memo  to sync.
[...]

Nice!

One more question:

---8<--
@@ -88,7 +90,7 @@
         osync_trace(TRACE_ENTRY, "%s(%p, %p, %p, %p)", __func__, sink, info, ctx, userdata);
  	OSyncEvoCalendar * evo_cal = (OSyncEvoCalendar *)userdata;
 
-	if (!(evo_cal->calendar = evo2_ecal_open_cal(evo_cal->uri, evo_cal->source_type, &error))) {
+	if (!(evo_cal->calendar = evo2_ecal_open_cal(evo_cal->uri, "Personnel", evo_cal->source_type, 
&error))) {
 		goto error;
 	}
---8<---

In this diff hunk you set "Personnel" - is this hardcoded string intended at this place?


> 
> <Name>....</Name> : it's to select the good entry in evolution.
> 
> (idem for calendar, memo and tasks)

Do you know if the <Name/> value is language dependent in evoulation?
If so, do you know any language indepenent good default value?
You wrote in the default configuration "Personnal" in the plugin-code "Personnel".

Best Regards,
Daniel


-- 
Daniel Gollub
Linux Consultant & Developer
Tel.: +49-160 47 73 970 
Mail: go...@b1...

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537