Re: [Opensync-devel] missing code in opensync_obj_engine.c

[Chris F. <cd...@fo...>]

Hi Daniel,

I believe this fixes it, but would appreciate your double-check and
confirmation.

Thanks,
- Chris


http://repo.or.cz/w/opensync/opensync-cdf.git/blobdiff/184c3b0375a83722c1b0ca144bc41c3bc8998d23..2e54e5125aee9d0a4d8479c1276b7cc49db82677:/opensync/engine/opensync_obj_engine.c



--- a/opensync/engine/opensync_obj_engine.c
+++ b/opensync/engine/opensync_obj_engine.c
@@ -930,8 +930,17 @@ static int _osync_obj_engine_num_write_sinks(OSyncObjEngine *objengine) {
        osync_trace(TRACE_ENTRY, "%s(%p)", __func__, objengine);
 
        for (p = objengine->sink_engines; p; p = p->next) {
+               OSyncMember *member = NULL;
+               OSyncObjTypeSink *objtype_sink = NULL;
+
                sink = p->data;
+               member = osync_client_proxy_get_member(sink->proxy);
+               objtype_sink = osync_member_find_objtype_sink(member, objengine->objtype);
 
+               /* Is the objtype_sink writable? */
+               if (objtype_sink && osync_objtype_sink_get_write(objtype_sink)) {
+                       num++;
+               }
 
        }
 

On Tue, Jun 28, 2011 at 04:39:36PM -0400, Chris Frey wrote:
> Hi Daniel,
> 
> Here's the commit in question:
> 
> http://repo.or.cz/w/opensync/opensync-cdf.git/commit/865414da0d3ffff2a7865fce9c82adcd7587c218
> 
> And the diff:
> 
> http://repo.or.cz/w/opensync/opensync-cdf.git/blobdiff/7f03a5a20921288dd7015777e6b9e648e73624bf..865414da0d3ffff2a7865fce9c82adcd7587c218:/opensync/engine/opensync_obj_engine.c
> 
> The function _osync_obj_engine_num_write_sinks() appears to be incomplete.
> 
> Could you give me an overview of what you intended?
> 
> Thanks!
> - Chris
> 
> 
> ------------------------------------------------------------------------------
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security 
> threats, fraudulent activity, and more. Splunk takes this data and makes 
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Opensync-devel mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/opensync-devel