Re: [Opensync-devel] Gnokii patch

[deloptes <del...@ya...>]

Quentin Denis wrote:

> Hi folks,
> 
> may I ask you to verify this patch? Emanoil, do you now have access to
> commit into the gnokii directory in SVN?

Don't know, but I've updated from svn, and it seems that David ( according
svn log ) applied last changes

> 
> With this patch I removed all the warnings, except the ones related to the
> calendar support. Once you have approved my contact changes, I will apply
> them on calendar since it's the same code.
> 
> However, the plugin still not listed in osynctool. I am wondering if this
> is because of the remaining warnings (only related to calendar then) or
> because something fundamental is missing. Any idea?

For me it is now

osynctool --listplugins
Available plugins:
file-sync
evo2-sync
akonadi-sync
syncml-http-server
syncml-http-client
syncml-obex-client
gnokii-sync


> 
> I think most of the changes should be correct, but I would like to catch
> your attention to the modifcations I did in the get/commit_changes
> functions (gnokii_contact.c) with all the sink and format stuff changes.
> Please make sure everything is okay there.
> 

I still get this warning

/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:
In function ‘gnokii_config_parse’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:173:
warning: ‘gn_cfg_memory_read’ is deprecated (declared
at /usr/include/gnokii.h:266)
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:173:
warning: passing argument 1 of ‘gn_cfg_memory_read’ from incompatible
pointer type
/usr/include/gnokii.h:266: note: expected ‘const char **’ but argument is of
type ‘char **’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:174:
warning: ‘gn_cfg_phone_load’ is deprecated (declared
at /usr/include/gnokii.h:273)

regards