Re: [Opensync-devel] Gnokii patch

[Emanoil K. <del...@ya...>]

Quentin Denis wrote:

> Here is a patch to make the gnokii plugin compile against the latest api.
> However, the plugin does not register yet and there are still warnings
> during compilation but I think this patch is a good starting point. Could
> anyone commit the changes since I have no access to svn?

I couldn't apply the patch, but I had a look into the code and the messages below

it looks like the code does not fit the recent gnokii*.h definitions, so much more needs to be done.

Daniel, do you intend to work on the code in (near) future?

gnokii could provide contact and calendar sync  (if we are lucky).

Does someone know if it would work with symbian?

here the warnings

/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c: In function ‘gnokii_config_parse’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:173: warning: ‘gn_cfg_memory_read’ is deprecated (declared at /usr/include/gnokii.h:266)
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:173: warning: passing argument 1 of ‘gn_cfg_memory_read’ from incompatible pointer type
/usr/include/gnokii.h:266: note: expected ‘const char **’ but argument is of type ‘char **’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:174: warning: ‘gn_cfg_phone_load’ is deprecated (declared at /usr/include/gnokii.h:273)
[ 77%] Building C object src/CMakeFiles/gnokii-sync.dir/gnokii_sync.o
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c: In function ‘initialize’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:199: warning: passing argument 2 of ‘osync_objtype_sink_set_connect_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:615: note: expected ‘OSyncSinkConnectFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:200: warning: passing argument 2 of ‘osync_objtype_sink_set_disconnect_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:629: note: expected ‘OSyncSinkDisconnectFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:215: warning: passing argument 2 of ‘osync_objtype_sink_set_get_changes_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:617: note: expected ‘OSyncSinkGetChangesFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:216: warning: passing argument 2 of ‘osync_objtype_sink_set_commit_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:619: note: expected ‘OSyncSinkCommitFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *, struct OSyncChange *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:217: warning: passing argument 2 of ‘osync_objtype_sink_set_sync_done_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:625: note: expected ‘OSyncSinkSyncDoneFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:248: warning: passing argument 2 of ‘osync_objtype_sink_set_get_changes_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:617: note: expected ‘OSyncSinkGetChangesFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:249: warning: passing argument 2 of ‘osync_objtype_sink_set_commit_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:619: note: expected ‘OSyncSinkCommitFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *, struct OSyncChange *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:250: warning: passing argument 2 of ‘osync_objtype_sink_set_sync_done_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:625: note: expected ‘OSyncSinkSyncDoneFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c: In function ‘get_sync_info’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:296: warning: passing argument 2 of ‘osync_plugin_set_discover’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_plugin.h:237: note: expected ‘discover_fn’ but argument is of type ‘osync_bool (*)(void *, struct OSyncPluginInfo *, struct OSyncError **)’
[ 88%] Building C object src/CMakeFiles/gnokii-sync.dir/gnokii_calendar.o
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calendar.c: In function ‘gnokii_calendar_get_changes’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calendar.c:345: warning: initialization makes pointer from integer without a cast
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calendar.c:355: warning: initialization makes pointer from integer without a cast
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calendar.c: In function ‘gnokii_calendar_commit_change’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calendar.c:476: warning: initialization makes pointer from integer without a cast
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calendar.c:477: warning: initialization makes pointer from integer without a cast
[100%] Building C object src/CMakeFiles/gnokii-sync.dir/gnokii_contact.o
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_contact.c: In function ‘gnokii_contact_get_changes’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_contact.c:393: warning: initialization makes pointer from integer without a cast
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_contact.c:396: warning: initialization makes pointer from integer without a cast
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_contact.c: In function ‘gnokii_contact_commit_change’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_contact.c:562: warning: initialization makes pointer from integer without a cast
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_contact.c:563: warning: initialization makes pointer from integer without a cast
Linking C shared module gnokii-sync.so
[100%] Built target gnokii-sync