Re: [Opensync-devel] Two brakes in libopensync

[Michael B. <mb...@gm...>]

On Mon, Oct 18, 2010 at 05:45:28PM +0200, Quentin Denis wrote:
> 1. The cmake macro MacroEnsureOutOfSourceBuild prevents from building the 
> sources within the source directory. OpenSync is the first source I know that 
> uses this annoying macro. Why? It makes the compilation process just more 
> painful, removing this macro will make things much easier. As far as I have 
> experienced, building outside the source directory has no advantage, so why 
> forcing it?

For the record, building out of the source tree is usual practise in
cmake-based projects anyway, though I am not aware of other projects
enforcing this.  One of the advantages is that you can easily clean up
your build tree by just removing it.
 
> 2. the __sun statement in opensync.h causes frequent troubles:
> [ 1%] Building CXX object 
> libqopensync/CMakeFiles/qopensync.dir/callbackhandler.o
> cc1plus: warnings being treated as errors In file included from 
> /home/murz/temp/2010-09/sync/kitchensync/libqopensync/callbackhandler.cpp:22:
> /usr/include/libopensync1/opensync/opensync.h:52: error: "__sun" is not 
> defined
> 
> How can we fix this issue? I do it by removing the lines 52-54 in opensync.h, 
> but this is only my simple workaround.

What compiler do you use?  Maybe very recent versions of gcc are more
picky about these kind of if/then/else macro structures.


Michael