Menu
▾
▴
Re: [Opensync-devel] possible issues in libwbxml
|
From: Michael B. <mic...@cm...> - 2010-10-15 15:40:24
|
On 10/13/10 20:25, deloptes wrote: > > After enabling debug and warnings at compile time I get warnings which might > lead to issues in libwbxml > > developer@lisa:~/opensync/libwbxml/trunk/build$ make && make install > Scanning dependencies of target wbxml2 > [ 5%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_base64.o > [ 11%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_buffers.o > /home/yoki/opensync/libwbxml/trunk/src/wbxml_buffers.c: In > function ‘wbxml_buffer_get_char’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_buffers.c:170: warning: > comparison of unsigned expression < 0 is always false Fixed by removing the comparison. > /home/yoki/opensync/libwbxml/trunk/src/wbxml_buffers.c: In > function ‘wbxml_buffer_strip_blanks’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_buffers.c:363: warning: > comparison of unsigned expression >= 0 is always true Fixed by removing the line. > /home/yoki/opensync/libwbxml/trunk/src/wbxml_buffers.c: In > function ‘grow_buff’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_buffers.c:709: warning: > comparison of unsigned expression < 0 is always false Fixed by removing the condition. All bugs in wbxml_buffers had no effect. > [ 16%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_charset.o > /home/yoki/opensync/libwbxml/trunk/src/wbxml_charset.c: In > function ‘binary_search’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_charset.c:317: warning: unused > parameter ‘in_buf’ > /home/yoki/opensync/libwbxml/trunk/src/wbxml_charset.c:318: warning: unused > parameter ‘in_buf_len’ > /home/yoki/opensync/libwbxml/trunk/src/wbxml_charset.c:319: warning: unused > parameter ‘in_seq’ > /home/yoki/opensync/libwbxml/trunk/src/wbxml_charset.c:320: warning: unused > parameter ‘in_seq_len’ > /home/yoki/opensync/libwbxml/trunk/src/wbxml_charset.c:321: warning: unused > parameter ‘out_pos’ The function binary_search is not implemented yet. Therefore you get a warning on the unused parameters. > [ 22%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_conv.o > [ 27%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_elt.o > [ 33%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_encoder.o > /home/yoki/opensync/libwbxml/trunk/src/wbxml_encoder.c: In > function ‘wbxml_encoder_set_flow_mode’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_encoder.c:623: warning: unused > parameter ‘flow_mode’ The parameter was simply ignored by the code. This is a real bug. Fixed. > /home/yoki/opensync/libwbxml/trunk/src/wbxml_encoder.c: In > function ‘parse_cdata’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_encoder.c:1346: warning: unused > parameter ‘node’ I created ticket #43. > /home/yoki/opensync/libwbxml/trunk/src/wbxml_encoder.c: In > function ‘parse_pi’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_encoder.c:1381: warning: unused > parameter ‘encoder’ > /home/yoki/opensync/libwbxml/trunk/src/wbxml_encoder.c:1381: warning: unused > parameter ‘node’ The function is not implemented yet. > /home/yoki/opensync/libwbxml/trunk/src/wbxml_encoder.c: In > function ‘wbxml_encode_wv_integer’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_encoder.c:3038: warning: > comparison of unsigned expression >= 0 is always true Fixed by using a signed integer. > [ 38%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_errors.o > [ 44%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_lists.o > [ 50%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_log.o > [ 55%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_mem.o > [ 61%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_parser.o > /home/yoki/opensync/libwbxml/trunk/src/wbxml_parser.c: In > function ‘wbxml_parser_parse’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_parser.c:246: warning: suggest > braces around empty body in an ‘if’ statement Fixed. > /home/yoki/opensync/libwbxml/trunk/src/wbxml_parser.c: In > function ‘check_public_id’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_parser.c:564: warning: > comparison between signed and unsigned integer expressions I created ticket #44 to track the issue. > /home/yoki/opensync/libwbxml/trunk/src/wbxml_parser.c: In > function ‘parse_switch_page’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_parser.c:1096: warning: suggest > braces around empty body in an ‘if’ statement Fixed. > /home/yoki/opensync/libwbxml/trunk/src/wbxml_parser.c: In > function ‘parse_opaque’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_parser.c:1748: warning: suggest > braces around empty body in an ‘if’ statement Fixed. > [ 66%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_tables.o > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tables.c: In > function ‘wbxml_tables_get_wbxml_publicid’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tables.c:3434: warning: > comparison between signed and unsigned integer expressions I created ticket #45 to track the issue. > [ 72%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_tree.o > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree.c: In > function ‘wbxml_tree_node_elt_get_from_name’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree.c:752: warning: unused > parameter ‘recurs’ I created ticket #46 to track the issue. > [ 77%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_tree_clb_wbxml.o > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_wbxml.c: In > function ‘wbxml_tree_clb_wbxml_start_element’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_wbxml.c:63: warning: > unused parameter ‘empty’ I created ticket #47 to track the issue. > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_wbxml.c: In > function ‘wbxml_tree_clb_wbxml_end_element’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_wbxml.c:81: warning: > unused parameter ‘element’ > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_wbxml.c:81: warning: > unused parameter ‘empty’ This is part of ticket #47. > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_wbxml.c: In > function ‘wbxml_tree_clb_wbxml_pi’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_wbxml.c:217: warning: > unused parameter ‘ctx’ > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_wbxml.c:217: warning: > unused parameter ‘target’ > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_wbxml.c:217: warning: > unused parameter ‘data’ This function is not implemented yet. > [ 83%] Building C object src/CMakeFiles/wbxml2.dir/wbxml_tree_clb_xml.o > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_xml.c: In > function ‘wbxml_tree_clb_xml_decl’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_xml.c:49: warning: > unused parameter ‘standalone’ I created ticket #48 to track the issue. > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_xml.c: In > function ‘wbxml_tree_clb_xml_doctype_decl’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_xml.c:73: warning: > unused parameter ‘doctypeName’ > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_xml.c:76: warning: > unused parameter ‘has_internal_subset’ I created ticket #49 to track the issue. > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_xml.c: In > function ‘wbxml_tree_clb_xml_pi’: > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_xml.c:532: warning: > unused parameter ‘target’ > /home/yoki/opensync/libwbxml/trunk/src/wbxml_tree_clb_xml.c:533: warning: > unused parameter ‘data’ The function is not implemented yet (PI is widely ignored today). I will check the newly created tickets over the next days. Best regards Michael -- ___________________________________________________________________ Michael Bell Humboldt-Universitaet zu Berlin Tel.: +49 (0)30-2093 70143 ZE Computer- und Medienservice Fax: +49 (0)30-2093 2704 Unter den Linden 6 mic...@cm... D-10099 Berlin ___________________________________________________________________ PGP Fingerprint: 09E4 3D29 4156 2774 0F2C C643 D8BD 1918 2030 5AAB |
