Re: [Opensync-devel] [PATCH] Important fix to libgcal-0.9.5

[Adenilson C. <cav...@gm...>]

Chris

I've checked the patches, and I got to say that I liked it (you even
remembered adding the examples from libgcal website, this is something
I was supposed to do ages ago...).
:-)

I'm just not sure about this one:
http://repo.or.cz/w/libgcal/libgcal-cdf.git/blobdiff/6f74f867f1af0ddafa8bc96a63d3a664c09f5605..b8096cbef66527a0ec778dbf40cc47b5af202501:/src/gcal.c

Why add a new function to delete an event if gcalendar.h already has it?
332 int gcal_erase_event(gcal_t gcal_obj, gcal_event_t event)?


The organization in libgcal is:
a) gcal.h has the dirty and tricky parts of doing the stuff
b) gcalendar.h has the 'public' API, hiding some complexities.

Finally, it seems to be a misunderstanding: IIRC, the edit url is the
same used to do edit and delete operations, the difference is that you
will use a HTTP PUT for edit and HTTP DELETE to erase an entry
(without the need to add the payload entry in the request). I assume
that you are already familiar with this, right? I suggest you to read
this:
http://code.google.com/apis/calendar/data/2.0/developers_guide_protocol.html#DeletingEvents

So, after we worked this minor issue, your patches are clean to go
into libgcal mainstream. Again, if you can, I suggest to base yourself
using the gitorious repository, since it has a better and cleaner
interface for me to handle merge requests.


Adenilson

On Fri, Aug 27, 2010 at 7:30 PM, Chris Frey <cd...@fo...> wrote:
> Thanks.  I've updated my repo.or.cz fork with your latest gitorious code,
> and rebased my code on top of it.
>
> The main google page for libgcal still points to repo.or.cz.
>
> - Chris
>
>
> On Fri, Aug 27, 2010 at 07:03:38PM -0400, Adenilson Cavalcanti wrote:
>> Chris
>>
>> The current devel repo of libgcal is:
>> http://gitorious.org/libgcal
>>
>> I will remove the link to or.cz soon...
>>
>>
>> Regards
>>
>>
>> Adenilson
>>
>> On Fri, Aug 27, 2010 at 6:19 PM, Chris Frey <cd...@fo...> wrote:
>> > On Wed, Aug 25, 2010 at 02:10:03PM -0400, Chris Frey wrote:
>> >> On Wed, Aug 25, 2010 at 01:52:12PM -0400, Adenilson Cavalcanti wrote:
>> >> > > Perhaps libgcal needs a cleanup function of its own, that the application
>> >> > > should call when closing. ?i.e. the sample apps should call libgcal's
>> >> > > cleanup function, which then calls xmlCleanupParser().
>> >> >
>> >> > Maybe adding a call to it when the gcal_t context is destroyed?
>> >>
>> >> I think it should be a separate call, because an application might be
>> >> finished with libgcal but not finished with libxml2, and needs to have
>> >> control over when libxml2 goes away.
>> >
>> > Hi Adenilson,
>> >
>> > I believe you're super busy, so I've taken the liberty of creating
>> > a forked repo on repo.or.cz to push my changes to. ?I've added
>> > the above cleanup fix, added the examples to the tree, added
>> > a final cleanup function (as well as added it to the examples),
>> > and added a new gcal_delete_entry_url() call.
>> >
>> > Please give them a look. ?Hopefully they are clean enough that you can
>> > just pull and release, but if not, let me know what needs fixing.
>> >
>> > Forked repo:
>> >
>> > ? ? ? ?http://repo.or.cz/w/libgcal/libgcal-cdf.git
>> >
>> > Thanks,
>> > - Chris
>> >
>> >
>>
>> ------------------------------------------------------------------------------
>> Sell apps to millions through the Intel(R) Atom(Tm) Developer Program
>> Be part of this innovative community and reach millions of netbook users
>> worldwide. Take advantage of special opportunities to increase revenue and
>> speed time-to-market. Join now, and jumpstart your future.
>> http://p.sf.net/sfu/intel-atom-d2d
>> _______________________________________________
>> Opensync-devel mailing list
>> Ope...@li...
>> https://lists.sourceforge.net/lists/listinfo/opensync-devel
>