Re: [Opensync-devel] leak in osync_member_get_config_or_default?

[Daniel G. <go...@b1...>]

Hi Chris,

On Friday 25 June 2010 02:43:36 pm Chris Frey wrote:
> On success it returns the member->config member directly.
> 
> On error, it loads the default from the default plugin config, calling
> osync_plugin_config_new(), then osync_member_set_config() which seems
> to bump the ref, then returns.

Right.

> 
> So a caller to osync_member_get_config_or_default() doesn't know whether
> to unref the result or not...


The caller doesn't have to unref - since OSyncPluginConfig* gets (in this 
function) or is already assigned to a OSyncMember struct. Once later one get 
freed the OSyncPluginConfig get's also unrefed.

Does this make sense?


Best Regards,
Daniel

-- 
Daniel Gollub                        Geschaeftsfuehrer: Ralph Dehner
Linux Consultant & Developer         Unternehmenssitz:  Vohburg
B1 Systems GmbH                      Amtsgericht:       Ingolstadt
Mobil: +49-(0)-160 47 73 970         Handelsregister:   HRB 3537
EMail: go...@b1...          http://www.b1-systems.de

Adresse: B1 Systems GmbH, Osterfeldstraße 7, 85088 Vohburg
http://pgpkeys.pca.dfn.de/pks/lookup?op=get&search=0xED14B95C2F8CA78D