[Opensync-commits] r6020 - plugins/ldap-sync/src

[<svn...@op...>]

Author: scriptor
Date: Sat Jan 23 17:58:40 2010
New Revision: 6020
URL: http://www.opensync.org/changeset/6020

Log:
Not fully sure about those calls to osync_change_unref().  They do
not seem to play well together with my destroy function.  Anyway,
I haven't finished testing it, yet.

Modified:
   plugins/ldap-sync/src/ldap_plugin.c

Modified: plugins/ldap-sync/src/ldap_plugin.c
==============================================================================
--- plugins/ldap-sync/src/ldap_plugin.c	Sat Jan 23 17:49:49 2010	(r6019)
+++ plugins/ldap-sync/src/ldap_plugin.c	Sat Jan 23 17:58:40 2010	(r6020)
@@ -1473,7 +1473,7 @@
 
 		osync_hashtable_update_change(hashtable, change);
 
-		osync_change_unref(change);
+		// osync_change_unref(change);
 		osync_trace(TRACE_EXIT, "%s", __func__);
 		return TRUE;
 	}
@@ -1484,7 +1484,6 @@
 	OSyncObjFormat *format_type = sinkenv->objformat;
 	if (format_type == NULL) {
 		osync_error_set(error, OSYNC_ERROR_GENERIC, "%s:%i: ERROR: format_type = NULL. Objtype = \"%s\"\n", __FILE__, __LINE__, osync_objtype_sink_get_name(sinkenv->sink));
-		osync_change_unref(change);
 		goto error;
 	} 
 #ifdef DEBUG_convert_ldap2xmlinternal
@@ -1532,7 +1531,6 @@
 	osync_trace(TRACE_INTERNAL, "%s:%i: sizeof(*to_be_reported) = %lu", __FILE__, __LINE__, sizeof(*to_be_reported));
 	if (sizeof(*to_be_reported) == 0) {
 		osync_error_set(error, OSYNC_ERROR_GENERIC,  "%s:%i: ERROR: sizeof(*to_be_reported) is 0.\n", __FILE__, __LINE__);
-		osync_change_unref(change);
 		goto error;
 	}
 	
@@ -1541,7 +1539,6 @@
 	odata = osync_data_new((char *)to_be_reported, sizeof(*to_be_reported), format_type, error);
 	if (!odata) {
 		osync_error_set(error, OSYNC_ERROR_GENERIC,  "%s:%i: ERROR: osync_data_new() has failed.\n", __FILE__, __LINE__);
-		osync_change_unref(change);
 		goto error;
 	}
 
@@ -1582,8 +1579,8 @@
 	if (odata)
 		osync_data_unref(odata);
 
-	if (change)
-		osync_change_unref(change);
+	// if (change)
+	// 	osync_change_unref(change);
 	
 	if (uid)
 		g_free(uid);
@@ -1600,8 +1597,8 @@
 	if (odata)
 		osync_data_unref(odata);
 
-	if (change)
-		osync_change_unref(change);
+	// if (change)
+	// 	osync_change_unref(change);
 
 	if (uid)
 		g_free(uid);