[Opensync-commits] r5981 - format-plugins/xmlformat/trunk/src

[<svn...@op...>]

Author: dgollub
Date: Sun Jan 10 15:59:08 2010
New Revision: 5981
URL: http://www.opensync.org/changeset/5981

Log:
Added TODO comments  about avoiding sorting.
Sorting is complex: O(N) and causes performance looses...

refs #923

Modified:
   format-plugins/xmlformat/trunk/src/xmlformat.c

Modified: format-plugins/xmlformat/trunk/src/xmlformat.c
==============================================================================
--- format-plugins/xmlformat/trunk/src/xmlformat.c	Sun Jan 10 15:57:16 2010	(r5980)
+++ format-plugins/xmlformat/trunk/src/xmlformat.c	Sun Jan 10 15:59:08 2010	(r5981)
@@ -67,7 +67,8 @@
 		return FALSE;
 	}
 
-	if(!osync_xmlformat_sort(xmlformat, error)) {
+	/* TODO: Try to avoid sorting */
+	if (!osync_xmlformat_sort(xmlformat, error)) {
 		osync_trace(TRACE_EXIT_ERROR, "%s: %s", __func__, osync_error_print(error));
 		return FALSE;
 	}
@@ -308,6 +309,7 @@
 
 	osync_trace(TRACE_ENTRY, "%s(%p, %u, %p, %p)", __func__, data, size, attribute, error);
 
+	/* TODO: Avoid sorting somehow */
 	if (!osync_xmlformat_sort((OSyncXMLFormat *)data, error))
 		goto error;