[Opensync-commits] r5940 - plugins/syncml/src

[<svn...@op...>]

Author: dgollub
Date: Thu Nov  5 20:16:33 2009
New Revision: 5940
URL: http://www.opensync.org/changeset/5940

Log:
Workaround wrong de-reference calls of the disconnect context which
seems to get called too often. Which caused an segfault on disconnenct
...

Modified:
   plugins/syncml/src/syncml_common.c

Modified: plugins/syncml/src/syncml_common.c
==============================================================================
--- plugins/syncml/src/syncml_common.c	Thu Nov  5 20:10:05 2009	(r5939)
+++ plugins/syncml/src/syncml_common.c	Thu Nov  5 20:16:33 2009	(r5940)
@@ -244,7 +244,12 @@
 	{
 		/* The disconnect already happened or
 		 * the session never existed (connect error). */
-		report_success_on_context(&ctx);
+		/* FIXME: at this point there seems to be already one reference taken:
+		 * report_success_on_context(&ctx);
+		 *
+		 * use the regular context_report_success to avoid double-free
+		 */
+    		osync_context_report_success(ctx);
 	} else {
 		env->disconnectCtx = ctx;
 		osync_context_ref(env->disconnectCtx);