Re: [Opensync-devel] [RFC][PATCH] OSYNC_START_TYPE_EXTERNAL

[Henrik /K. <he...@ka...>]

Daniel Gollub wrote:
> On Wednesday 28 October 2009 10:04:43 pm Henrik /KaarPoSoft wrote:
>   
>> Please let me know if anybody objects to me checking in the attached
>> combined patch for all the issues I have raised about
>> OSYNC_START_TYPE_EXTERNAL so far.
>>     
>
> I like the command_start addition .. this is somethign which was really 
> missing. Could you explain how you use this for mozilla-sync?
>
> Do you start mozilla if it isn't already started? Or do you trigger the sync 
> via an additional command? Or both?
>   
If you call the "thunderbird" program, it will start a new process if it 
is not already running. I thunderbird is already running, it will simply 
hand off the command line parameters to the already running instance.

The opensync client is triggered by the -mozilla-sync command line 
option which I added to thunderbird.

The sync itself can be triggered by running the engine from osynctool or 
from inside the blueZync plugin to Thunderbird.
> I'm still not convinced why there is need to overwrite the plugindir ... or 
> maybe i didn't understand the problem. Unfortuantely exactly for the new API 
> function to override the path the API documentation is missing why this is 
> needed ...
>
> +OSYNC_EXPORT void osync_client_set_overriding_plugin_dir(OSyncClient *client, 
> char *overriding_plugin_dir);
> +OSYNC_EXPORT char *osync_client_get_overriding_plugin_dir(OSyncClient 
> *client);
> +
>   
As I wrote in a different thread, I am not sure if my way of 
implementing the external process is the intended one. I am simply 
running the same kind of client that would have been running inside 
osynctool, by calling the same opensync libraries. That means that 
without osync_client_get_overriding_plugin_dir the opensync library 
would load the slim mozilla-sync plugin which was intended for 
osynctool/engine, not the new fat mozilla-sync plugin intended for the 
external process.

/Henrik