Re: [Opensync-devel] demerge_xmlformat does not demerge second level

[Daniel G. <go...@b1...>]

On Wednesday 21 October 2009 06:57:55 pm Henrik /KaarPoSoft wrote:
[...]
> However, on the second level, if we have a <LastName> inside a <Name> in
> the xmlformat, but not in the capabilities, the field is *not* deleted,
> instead the value of the field is set to blank.
> 
> This breaks the logic in xmlformat_compare, which will "Run out of list2
> elements".
[...]
> (1) Does anyone know, WHY the second level of demerge_xmlformat was
> implemented like this? I.e. something that would break if we remove the
> field instead of blanking it?

Hmmm... no idea. I could imagine thats indeed a bug ...

> 
> (2) The top-level loop in demerge_xmlformat efficiently runs through the
> xml fileds with functions like osync_xmlfield_get_next. But the second
> level inefficiently uses indexes into the lists with functions like
> osync_xmlfield_get_nth_key_name. Is there any particular reason for this?
[...]

I could imagine this was very ugly porting when dropping the 2-level limit of 
the xmlformat API to a n-level design.

Best Regards,
Daniel

-- 
Daniel Gollub                        Geschaeftsfuehrer: Ralph Dehner
FOSS Developer                       Unternehmenssitz:  Vohburg
B1 Systems GmbH                      Amtsgericht:       Ingolstadt
Mobil: +49-(0)-160 47 73 970         Handelsregister:   HRB 3537
EMail: go...@b1...          http://www.b1-systems.de

Adresse: B1 Systems GmbH, Osterfeldstraße 7, 85088 Vohburg
http://pgpkeys.pca.dfn.de/pks/lookup?op=get&search=0xED14B95C2F8CA78D