Re: [Opensync-devel] [RFC] Change order of main/objtype plugin-sink function calls?

[Henrik /K. <kaa...@us...>]

Hi,

I am sorry, but I do not think this is a question of whether the patch 
works.

As far as I am concerned, the modified proposed sequence is the "right" one:

1. Connect:
   1.1 Main Sink connect()         <----- AS PROPOSED
   1.2 ObjType Sink connect()      <----- AS PROPOSED

2. Connect Done:
   2.1 ObjType Sink connect_done() <----- FIFO
   2.2 Main Sink connect_done()    <----- MAIN SINK LAST


If everyone agrees that this is "conceptually" the right thing to do,
it should be implemented in OpenSync, and if plugins need to be adjusted,
so be it.

/Henrik


Daniel Gollub wrote:
> On Saturday 17 October 2009 05:52:22 pm Paul Eggleton wrote:
>   
>> Hi all,
>>
>> So, any further thoughts/objections on this one? If not, it would be nice
>>  to get the change made (at least for the connect)
>>     
> [...]
>
> Did you try the proof of concept patch? Is your plugin working with this patch 
> as expected?
>
> Best Regards,
> Daniel
>
>