From: <svn...@op...> - 2009-10-01 14:08:40
|
Author: bellmich Date: Thu Oct 1 14:47:47 2009 New Revision: 1295 URL: http://libsyncml.opensync.org/changeset/1295 Log: removed useless code which additionally produced a memory leak Modified: trunk/libsyncml/data_sync_api/sml_data_sync_data_store_session.c Modified: trunk/libsyncml/data_sync_api/sml_data_sync_data_store_session.c ============================================================================== --- trunk/libsyncml/data_sync_api/sml_data_sync_data_store_session.c Wed Sep 30 17:22:41 2009 (r1294) +++ trunk/libsyncml/data_sync_api/sml_data_sync_data_store_session.c Thu Oct 1 14:47:47 2009 (r1295) @@ -342,35 +342,6 @@ sml_data_sync_change_item_get_action(item) == SML_CHANGE_REPLACE) sml_data_sync_change_item_set_action(item, SML_CHANGE_ADD); - /* decode base64 data if necessary */ - gchar *data = NULL; - gsize length = 0; - const gchar *ct = sml_data_sync_data_store_get_content_type(session->priv->data_store); - size_t appClassLength = ((size_t) index(ct, '/')) - - ((size_t) ct); - if ( ( strstr(ct, SML_CONTENT_TYPE_APPLICATION) == ct && - appClassLength == strlen(SML_CONTENT_TYPE_APPLICATION) ) || - ( strstr(ct, SML_CONTENT_TYPE_AUDIO) == ct && - appClassLength == strlen(SML_CONTENT_TYPE_AUDIO) ) || - ( strstr(ct, SML_CONTENT_TYPE_IMAGE) == ct && - appClassLength == strlen(SML_CONTENT_TYPE_IMAGE) ) || - ( strstr(ct, SML_CONTENT_TYPE_MESSAGE) == ct && - appClassLength == strlen(SML_CONTENT_TYPE_MESSAGE) ) || - ( strstr(ct, SML_CONTENT_TYPE_VIDEO) == ct && - appClassLength == strlen(SML_CONTENT_TYPE_AUDIO) ) ) - { - /* binary data must be base64 encoded */ - data = (char *) g_base64_decode(sml_data_sync_change_item_get_data(item), &length); - if (!data) { - g_set_error(error, SML_ERROR, SML_ERROR_GENERIC, - "The base 64 decoding of glib failed."); - goto error; - } - } else { - data = g_strdup(sml_data_sync_change_item_get_data(item)); - length = strlen(data); - } - /* perform callback */ if (!callback (session, item, userdata, error)) goto error; |