[Opensync-commits] r5695 - in branches/opensync-ticket1084: . opensync/capabilities

[<svn...@op...>]

Author: dgollub
Date: Wed Jul  8 11:10:35 2009
New Revision: 5695
URL: http://www.opensync.org/changeset/5695

Log:
Added and exported missing declartions/symbols of
osync_capability_{,un}ref()

Fixed compiler warnings about unused variables, goto statments.

Modified:
   branches/opensync-ticket1084/opensync.sym
   branches/opensync-ticket1084/opensync/capabilities/opensync_capability.c
   branches/opensync-ticket1084/opensync/capabilities/opensync_capability.h
   branches/opensync-ticket1084/opensync/capabilities/opensync_capability_internals.h

Modified: branches/opensync-ticket1084/opensync.sym
==============================================================================
--- branches/opensync-ticket1084/opensync.sym	Wed Jul  8 11:05:24 2009	(r5694)
+++ branches/opensync-ticket1084/opensync.sym	Wed Jul  8 11:10:35 2009	(r5695)
@@ -1,10 +1,10 @@
 osync_capabilities_get_format
-osync_capabilities_objtype_ref
-osync_capabilities_objtype_unref
 osync_capabilities_get_objtype
 osync_capabilities_new
 osync_capabilities_objtype_get_caps
 osync_capabilities_objtype_new
+osync_capabilities_objtype_ref
+osync_capabilities_objtype_unref
 osync_capabilities_ref
 osync_capabilities_unref
 osync_capability_get_displayname
@@ -16,6 +16,7 @@
 osync_capability_get_type
 osync_capability_get_valenums
 osync_capability_new
+osync_capability_ref
 osync_capability_set_displayname
 osync_capability_set_max
 osync_capability_set_maxoccurs
@@ -23,6 +24,7 @@
 osync_capability_set_name
 osync_capability_set_parameter
 osync_capability_set_type
+osync_capability_unref
 osync_change_compare
 osync_change_get_changetype
 osync_change_get_data

Modified: branches/opensync-ticket1084/opensync/capabilities/opensync_capability.c
==============================================================================
--- branches/opensync-ticket1084/opensync/capabilities/opensync_capability.c	Wed Jul  8 11:05:24 2009	(r5694)
+++ branches/opensync-ticket1084/opensync/capabilities/opensync_capability.c	Wed Jul  8 11:10:35 2009	(r5695)
@@ -146,14 +146,15 @@
 
 error_oom:	
 	osync_error_set(error, OSYNC_ERROR_GENERIC, "No memory left to assemble capability.");
+/*	
 error:
+*/
 	osync_trace(TRACE_EXIT_ERROR, "%s: %s" , __func__, osync_error_print(error));
 	return FALSE;
 }
 
 OSyncCapability *osync_capability_new(OSyncCapabilitiesObjType *capobjtype, OSyncError **error)
 {
-	OSyncList *l;
 	OSyncCapability *capability = NULL;
 	osync_trace(TRACE_ENTRY, "%s(%p, %s, %p)", __func__, capobjtype, error);
 	osync_assert(capobjtype);

Modified: branches/opensync-ticket1084/opensync/capabilities/opensync_capability.h
==============================================================================
--- branches/opensync-ticket1084/opensync/capabilities/opensync_capability.h	Wed Jul  8 11:05:24 2009	(r5694)
+++ branches/opensync-ticket1084/opensync/capabilities/opensync_capability.h	Wed Jul  8 11:10:35 2009	(r5695)
@@ -68,6 +68,9 @@
  */
 OSYNC_EXPORT OSyncCapability *osync_capability_new(OSyncCapabilitiesObjType* capobjtype, OSyncError **error);
 
+OSYNC_EXPORT OSyncCapability *osync_capability_ref(OSyncCapability *capability);
+OSYNC_EXPORT void osync_capability_unref(OSyncCapability *capability);
+
 /**
  * @brief Get the name of the capability
  * @param capability The pointer to a capability object

Modified: branches/opensync-ticket1084/opensync/capabilities/opensync_capability_internals.h
==============================================================================
--- branches/opensync-ticket1084/opensync/capabilities/opensync_capability_internals.h	Wed Jul  8 11:05:24 2009	(r5694)
+++ branches/opensync-ticket1084/opensync/capabilities/opensync_capability_internals.h	Wed Jul  8 11:10:35 2009	(r5695)
@@ -41,6 +41,10 @@
  */
 OSyncCapability *osync_capability_parse(OSyncCapabilitiesObjType *objtype, xmlNodePtr node, OSyncError **error);
 
+
+/* TODO - Doxygen */
+osync_bool osync_capability_assemble(OSyncCapability *cap, xmlNodePtr node, OSyncError **error);
+
 /**
  * @brief Frees a capability object 
  * @param capability The pointer to a capability object