[Opensync-commits] r5693 - branches/opensync-ticket1084/opensync/capabilities

[<svn...@op...>]

Author: dgollub
Date: Wed Jul  8 11:02:29 2009
New Revision: 5693
URL: http://www.opensync.org/changeset/5693

Log:
Changed signature of osync_capabilities_assemble()
Use for size a unsigned int for, to honor OpenSync' common API pattern
of types for size and lengths values.

Modified:
   branches/opensync-ticket1084/opensync/capabilities/opensync_capabilities.c
   branches/opensync-ticket1084/opensync/capabilities/opensync_capabilities_internals.h

Modified: branches/opensync-ticket1084/opensync/capabilities/opensync_capabilities.c
==============================================================================
--- branches/opensync-ticket1084/opensync/capabilities/opensync_capabilities.c	Wed Jul  8 11:00:02 2009	(r5692)
+++ branches/opensync-ticket1084/opensync/capabilities/opensync_capabilities.c	Wed Jul  8 11:02:29 2009	(r5693)
@@ -132,7 +132,7 @@
 	return NULL;
 }
 
-osync_bool osync_capabilities_assemble(OSyncCapabilities *capabilities, char **buffer, int *size, OSyncError **error)
+osync_bool osync_capabilities_assemble(OSyncCapabilities *capabilities, char **buffer, unsigned int *size, OSyncError **error)
 {
 	xmlDocPtr doc = NULL;
 	xmlNodePtr root;
@@ -167,7 +167,8 @@
 			goto error;
 	}
 
-	xmlDocDumpFormatMemoryEnc(doc, (xmlChar **) buffer, size, NULL, 1);
+	/* XXX Ugly cast, but we try to fit here the opensync API pattern of unsigned size/length types */
+	xmlDocDumpFormatMemoryEnc(doc, (xmlChar **) buffer, (int *) size, NULL, 1);
 	
 	return TRUE;
 

Modified: branches/opensync-ticket1084/opensync/capabilities/opensync_capabilities_internals.h
==============================================================================
--- branches/opensync-ticket1084/opensync/capabilities/opensync_capabilities_internals.h	Wed Jul  8 11:00:02 2009	(r5692)
+++ branches/opensync-ticket1084/opensync/capabilities/opensync_capabilities_internals.h	Wed Jul  8 11:02:29 2009	(r5693)
@@ -74,7 +74,7 @@
  * @return The xml document and the size of it. It's up to the caller to free
  *  the buffer. Always it return TRUE.
  */
-OSYNC_TEST_EXPORT osync_bool osync_capabilities_assemble(OSyncCapabilities *capabilities, char **buffer, int *size, OSyncError **error);
+OSYNC_TEST_EXPORT osync_bool osync_capabilities_assemble(OSyncCapabilities *capabilities, char **buffer, unsigned int *size, OSyncError **error);
 
 /**
  * @brief Creates a new capabilities object from an xml document.