[Opensync-commits] r5561 - in trunk: docs/whitepaper tests tests/engine-tests

[<svn...@op...>]

Author: bellmich
Date: Wed Apr  8 17:14:01 2009
New Revision: 5561
URL: http://www.opensync.org/changeset/5561

Log:
further batch_commit cleanups

- documentation
- CMakeLists.txt for test cases
- TODOs

Modified:
   trunk/docs/whitepaper/plugins.tex
   trunk/docs/whitepaper/synchronization.tex
   trunk/tests/CMakeLists.txt
   trunk/tests/engine-tests/check_engine.c

Modified: trunk/docs/whitepaper/plugins.tex
==============================================================================
--- trunk/docs/whitepaper/plugins.tex	Wed Apr  8 17:08:25 2009	(r5560)
+++ trunk/docs/whitepaper/plugins.tex	Wed Apr  8 17:14:01 2009	(r5561)
@@ -131,7 +131,7 @@
 Connect & Optional \\
 Connect Done & Optional \\
 Get Changes & Required \\ 
-Commit / Batch Commit & Required (only Commit \textbf{or} Batch Commit) \\ 
+Commit & Required \\ 
 Committed All & Optional (only available in combination with Commit)\\ 
 Synchronization Done & Optional \\ 
 Disconnect & Optional
@@ -183,14 +183,9 @@
 replied with \verb|osync_context_success()|. If Hashtable is already involved in
 the Get Changes functions, then the Commit function should update the Hashtable
 for the entries which get committed.
-\subsection{Batch Commit}
-The batch commit function is intended for protocols, device or application which
-only allow batch committing (sending all changes at once). This function gets
-called with an array of changes to be committed.
 \subsection{Committed All}
 This function is called after all entries have committed, even if error appeared
-while committing. This function is not called if a Batch Commit function is
-registered for this Sink.
+while committing.
 \subsection{Synchronization Done}
 This function is called only after a successful synchronization.  When using a
 Hashtable \verb|osync_hashtable_save()| should be called to store the Hashtable

Modified: trunk/docs/whitepaper/synchronization.tex
==============================================================================
--- trunk/docs/whitepaper/synchronization.tex	Wed Apr  8 17:08:25 2009	(r5560)
+++ trunk/docs/whitepaper/synchronization.tex	Wed Apr  8 17:14:01 2009	(r5561)
@@ -31,8 +31,7 @@
  information which doesn't allow to do a binary compare? Weak compare? Is 
  conversion to a common format for different parties required?
  \item Protocol. Does the protocol require to read only the latest changes or 
- all at once? Does the protocol support single commits or only all at once 
- (batch commit)?
+ all at once?
  \item Transport. Are various transport layer involved? Does it require to
  connect and disconnect in a specified way? Limited bandwidth? Example: 
  Bluetooth, USB, ...

Modified: trunk/tests/CMakeLists.txt
==============================================================================
--- trunk/tests/CMakeLists.txt	Wed Apr  8 17:08:25 2009	(r5560)
+++ trunk/tests/CMakeLists.txt	Wed Apr  8 17:14:01 2009	(r5561)
@@ -186,7 +186,6 @@
 OSYNC_TESTCASE( engine-error engine_error_commit_error_modify)
 OSYNC_TESTCASE( engine-error engine_error_commit_error_delete)
 OSYNC_TESTCASE( engine-error engine_error_committed_all_error)
-OSYNC_TESTCASE( engine-error engine_error_committed_all_batch_error)
 OSYNC_TESTCASE( engine-error engine_error_single_sync_done_error)
 OSYNC_TESTCASE( engine-error engine_error_dual_sync_done_error)
 OSYNC_TESTCASE( engine-error engine_error_triple_sync_done_error)

Modified: trunk/tests/engine-tests/check_engine.c
==============================================================================
--- trunk/tests/engine-tests/check_engine.c	Wed Apr  8 17:08:25 2009	(r5560)
+++ trunk/tests/engine-tests/check_engine.c	Wed Apr  8 17:14:01 2009	(r5561)
@@ -2032,7 +2032,6 @@
 OSYNC_TESTCASE_ADD(engine_sync_read_write_stress)
 OSYNC_TESTCASE_ADD(engine_sync_read_write_stress2)
 
-//batch commit
 //connect problem
 //get_changes problem