[Opensync-commits] r5378 - in trunk: . opensync/plugin

[<svn...@op...>]

Author: dgollub
Date: Sat Mar 28 16:02:45 2009
New Revision: 5378
URL: http://www.opensync.org/changeset/5378

Log:
Drop osync_plugin_info_get_configdir() from plugin interface to avoid
that plugins directly access the filesystem of the configuration
direcoty. This hopefully avoids an maintenance nightmare.

osync_plugin_info_get_configdir() will not get replaced by any other
function.

fixes #1083

Modified:
   trunk/opensync.sym
   trunk/opensync/plugin/opensync_objtype_sink.c
   trunk/opensync/plugin/opensync_plugin_info.h
   trunk/opensync/plugin/opensync_plugin_info_internals.h

Modified: trunk/opensync.sym
==============================================================================
--- trunk/opensync.sym	Sat Mar 28 15:49:50 2009	(r5377)
+++ trunk/opensync.sym	Sat Mar 28 16:02:45 2009	(r5378)
@@ -547,7 +547,6 @@
 osync_plugin_info_find_objtype
 osync_plugin_info_get_capabilities
 osync_plugin_info_get_config
-osync_plugin_info_get_configdir
 osync_plugin_info_get_format_env
 osync_plugin_info_get_groupname
 osync_plugin_info_get_loop

Modified: trunk/opensync/plugin/opensync_objtype_sink.c
==============================================================================
--- trunk/opensync/plugin/opensync_objtype_sink.c	Sat Mar 28 15:49:50 2009	(r5377)
+++ trunk/opensync/plugin/opensync_objtype_sink.c	Sat Mar 28 16:02:45 2009	(r5378)
@@ -28,7 +28,7 @@
 #include "opensync/helper/opensync_anchor_internals.h"
 #include "opensync/helper/opensync_hashtable_internals.h"
 
-#include "opensync_plugin_info.h" /* due to osync_plugin_info_get_configdir() */
+#include "opensync_plugin_info_internals.h" /* due to osync_plugin_info_get_configdir() */
 
 #include "opensync_objtype_sink.h"
 #include "opensync_objtype_sink_internals.h"

Modified: trunk/opensync/plugin/opensync_plugin_info.h
==============================================================================
--- trunk/opensync/plugin/opensync_plugin_info.h	Sat Mar 28 15:49:50 2009	(r5377)
+++ trunk/opensync/plugin/opensync_plugin_info.h	Sat Mar 28 16:02:45 2009	(r5378)
@@ -93,15 +93,6 @@
  */
 OSYNC_EXPORT void osync_plugin_info_set_configdir(OSyncPluginInfo *info, const char *configdir);
 
-/** @brief Returns the plugin configuration directory
- * 
- * @param info Pointer to the plugin info object
- * @returns the full path where configuration files for the plugin are stored
- * 
- */
-OSYNC_EXPORT const char *osync_plugin_info_get_configdir(OSyncPluginInfo *info);
-
-
 /** @brief Find ObjTypeSink of corresponding Object Type in OSyncPluginInfo object
  * 
  * @param info Pointer to the OSyncPluginInfo object

Modified: trunk/opensync/plugin/opensync_plugin_info_internals.h
==============================================================================
--- trunk/opensync/plugin/opensync_plugin_info_internals.h	Sat Mar 28 15:49:50 2009	(r5377)
+++ trunk/opensync/plugin/opensync_plugin_info_internals.h	Sat Mar 28 16:02:45 2009	(r5378)
@@ -36,6 +36,14 @@
  */
 OSyncObjTypeSink *osync_plugin_info_get_sink(OSyncPluginInfo *info);
 
+/** @brief Returns the plugin configuration directory
+ * 
+ * @param info Pointer to the plugin info object
+ * @returns the full path where configuration files for the plugin are stored
+ * 
+ */
+OSYNC_TEST_EXPORT const char *osync_plugin_info_get_configdir(OSyncPluginInfo *info);
+
 /*@}*/