New feature for barcode
Brought to you by:
jekkos,
pappastech
Menu
▾
▴
1 Attachments
#25 New feature for barcode
Dear,
Here is a patch base on this request
https://sourceforge.net/p/opensourcepos/discussion/1817181/thread/e1a38639/
There are 2 parts relate to this change
- Config part => I have add a config tab for barcode
- Generate barcode => Add logic to generate barcode follow the config
Discussion
The base code is on version 2.1 (not sure)
If you need any support please let me know
OK thanks for the patch! Will look into it but first need to release 2.3.1 (which will contain some new stuff + bug fixes for multistore support)
Maybe make a pull request from github as most development is done on that site now. Will be easier for me to integrate in the end (and for you to keep uptodate)
github.com/jekkos/opensourcepos
ok I will update and send you a new patch soon
How to apply this patch to 2.1 version? can you please specify?
How to apply this patch, there is no direction.
Ok I gave this a shot this morning. Looks like the barcode_lib.php is missing in the patch. Any idea what has to be in there?
OK I have finished integrating the proposed patch. However there are some licensing issues with the included barcodegen library. This one is NOT free for commercial use and probably redesitribution is not allowed. Also every user will require a separate license per server.
Big thanks to Jekkos helped to merge code.
In case of licensing issues, I dont have knowledge. I have downloaded barcode generator source code form this site http://www.barcodephp.com/en/download. It is a free version. Not sure if we can use it in the project.
In ReadMe it said that "This script is free for personal use. The program is provide "AS IS" without warranty of any kind. If you want to use it as
commercial use, you have to purchase it". But our project is not for commercial. Right?
Jekkos,
As you said that "every user will require a separate license per server" what did you mean? The barcode is not worked on your site?
Yes I have a working setup with your patch on my local server now. I think most of the time users will use ospos in commercial setups (as a point of sale system). Also there is no note on redestribution coniditoins of the library.
In any case I think that, if we do want to include this library, then users will need to buy a license if they want to use it in their shops. This will make ospos a non free product.
Right now I think it's best to keep this version on a separate branch, remove the barcodegen specific settings and revert to the old Code39 generator and merge this with master. There will still be some improvement thanks to the configurabble barcode sheet and updated config tabs.
I agree with Jekkos, polluting open source code under a free license with one that is for commercial use is not a good idea.
Unless a plugin model is used the code should not be part of the main codeline.
Last edit: Francesco 2015-02-02
agree with you, sorry to west your time to merge the code. I didnt realize the licensing issues when I have implemented the feature T T
no problem the idea itself was ok. I removed the library and reworked the config a bit, sheets are now easily conifgurable (not on github yet but will be soon)
new barcode sheet generation was included in latest github version.