Thread: [OpenSIPStack] Contribute changes to OpenSIPStack?
Brought to you by:
joegenbaclor
Menu
▾
▴
opensipstack-devel
|
From: Matthias D. <mdr...@gm...> - 2008-06-04 05:08:37
Attachments:
RegisterSessionManager.cxx.patch
OpalOSSEndPoint.h.patch
|
Hello, I did some changes to OpenSIPStack. Now my question is if it is possible to contribute patches? OpalOSSEndPoint.h.patch: replaced private with protected in OpalOSSUserAgent to use derived SessionManager. RegisterSessionManager.cxx.patch: moved creation of "registry" folder to AddRegistrationRecovery(..) so it is only created if really needed. Regards, Matthias |
|
From: <jo...@op...> - 2008-06-04 05:25:15
|
Hi Matthias, I'll take a look. If they dont break anything, I'll commit it in CVS. I'll let you know. Joegen Matthias Dreißig wrote: > Hello, > > I did some changes to OpenSIPStack. Now my question is if it is > possible to contribute patches? > > OpalOSSEndPoint.h.patch: replaced private with protected in > OpalOSSUserAgent to use derived SessionManager. > > RegisterSessionManager.cxx.patch: moved creation of "registry" folder > to AddRegistrationRecovery(..) so it is only created if really needed. > > Regards, > Matthias > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > ------------------------------------------------------------------------ > > _______________________________________________ > opensipstack-devel mailing list > ope...@li... > https://lists.sourceforge.net/lists/listinfo/opensipstack-devel > ------------------------------------------------------------------------ > > Internal Virus Database is out-of-date. > Checked by AVG. > Version: 7.5.524 / Virus Database: 269.24.1/1463 - Release Date: 5/23/2008 3:36 PM |
|
From: Joegen E. B. <joe...@gm...> - 2008-06-04 05:56:47
|
Hi Matthias, Modified your patches a bit so that PFile::Exists( m_RegRecoveryDIR.c_str() ) will only be performed once within AddRegistrationRecovery(). Your patches are in. Thanks. Joegen jo...@op... wrote: > Hi Matthias, > > I'll take a look. If they dont break anything, I'll commit it in CVS. > I'll let you know. > > Joegen > > Matthias Dreißig wrote: > >> Hello, >> >> I did some changes to OpenSIPStack. Now my question is if it is >> possible to contribute patches? >> >> OpalOSSEndPoint.h.patch: replaced private with protected in >> OpalOSSUserAgent to use derived SessionManager. >> >> RegisterSessionManager.cxx.patch: moved creation of "registry" folder >> to AddRegistrationRecovery(..) so it is only created if really needed. >> >> Regards, >> Matthias >> ------------------------------------------------------------------------ >> >> ------------------------------------------------------------------------- >> Check out the new SourceForge.net Marketplace. >> It's the best place to buy or sell services for >> just about anything Open Source. >> http://sourceforge.net/services/buy/index.php >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> opensipstack-devel mailing list >> ope...@li... >> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >> ------------------------------------------------------------------------ >> >> Internal Virus Database is out-of-date. >> Checked by AVG. >> Version: 7.5.524 / Virus Database: 269.24.1/1463 - Release Date: 5/23/2008 3:36 PM >> > > > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ > opensipstack-devel mailing list > ope...@li... > https://lists.sourceforge.net/lists/listinfo/opensipstack-devel > > > |
|
From: Matthias D. <mdr...@gm...> - 2008-06-04 08:09:39
|
Thanks! In this context is it possible to contribute a patch where the "quanize" functions in q726 codecs files are renamed? We use the theora library and there is conflict with a function also called "quantize". Best Regards Matthias Joegen E. Baclor schrieb: > Hi Matthias, > > Modified your patches a bit so that PFile::Exists( > m_RegRecoveryDIR.c_str() ) will only be performed once within > AddRegistrationRecovery(). Your patches are in. > > Thanks. > > Joegen > > jo...@op... wrote: > >> Hi Matthias, >> >> I'll take a look. If they dont break anything, I'll commit it in CVS. >> I'll let you know. >> >> Joegen >> >> Matthias Dreißig wrote: >> >> >>> Hello, >>> >>> I did some changes to OpenSIPStack. Now my question is if it is >>> possible to contribute patches? >>> >>> OpalOSSEndPoint.h.patch: replaced private with protected in >>> OpalOSSUserAgent to use derived SessionManager. >>> >>> RegisterSessionManager.cxx.patch: moved creation of "registry" folder >>> to AddRegistrationRecovery(..) so it is only created if really needed. >>> >>> Regards, >>> Matthias >>> ------------------------------------------------------------------------ >>> >>> ------------------------------------------------------------------------- >>> Check out the new SourceForge.net Marketplace. >>> It's the best place to buy or sell services for >>> just about anything Open Source. >>> http://sourceforge.net/services/buy/index.php >>> ------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> opensipstack-devel mailing list >>> ope...@li... >>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >>> ------------------------------------------------------------------------ >>> >>> Internal Virus Database is out-of-date. >>> Checked by AVG. >>> Version: 7.5.524 / Virus Database: 269.24.1/1463 - Release Date: 5/23/2008 3:36 PM >>> >>> >> >> ------------------------------------------------------------------------- >> Check out the new SourceForge.net Marketplace. >> It's the best place to buy or sell services for >> just about anything Open Source. >> http://sourceforge.net/services/buy/index.php >> _______________________________________________ >> opensipstack-devel mailing list >> ope...@li... >> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >> >> >> >> > > > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ > opensipstack-devel mailing list > ope...@li... > https://lists.sourceforge.net/lists/listinfo/opensipstack-devel > > |
|
From: <jo...@op...> - 2008-06-04 10:03:12
|
it will be a bit of a bad precedent for me to accepts patches to change function names in the library because of conflicts. I'm sure theora authors would feel the same. However, theora support seems a good functionality to add to opensipstack. if you are willing to do that, then i might consider changing the name ;-) Matthias Dreißig wrote: > Thanks! > > In this context is it possible to contribute a patch where the "quanize" > functions in q726 codecs files are renamed? We use the theora library > and there is conflict with a function also called "quantize". > > Best Regards > Matthias > > Joegen E. Baclor schrieb: > >> Hi Matthias, >> >> Modified your patches a bit so that PFile::Exists( >> m_RegRecoveryDIR.c_str() ) will only be performed once within >> AddRegistrationRecovery(). Your patches are in. >> >> Thanks. >> >> Joegen >> >> jo...@op... wrote: >> >> >>> Hi Matthias, >>> >>> I'll take a look. If they dont break anything, I'll commit it in CVS. >>> I'll let you know. >>> >>> Joegen >>> >>> Matthias Dreißig wrote: >>> >>> >>> >>>> Hello, >>>> >>>> I did some changes to OpenSIPStack. Now my question is if it is >>>> possible to contribute patches? >>>> >>>> OpalOSSEndPoint.h.patch: replaced private with protected in >>>> OpalOSSUserAgent to use derived SessionManager. >>>> >>>> RegisterSessionManager.cxx.patch: moved creation of "registry" folder >>>> to AddRegistrationRecovery(..) so it is only created if really needed. >>>> >>>> Regards, >>>> Matthias >>>> ------------------------------------------------------------------------ >>>> >>>> ------------------------------------------------------------------------- >>>> Check out the new SourceForge.net Marketplace. >>>> It's the best place to buy or sell services for >>>> just about anything Open Source. >>>> http://sourceforge.net/services/buy/index.php >>>> ------------------------------------------------------------------------ >>>> >>>> _______________________________________________ >>>> opensipstack-devel mailing list >>>> ope...@li... >>>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >>>> ------------------------------------------------------------------------ >>>> >>>> Internal Virus Database is out-of-date. >>>> Checked by AVG. >>>> Version: 7.5.524 / Virus Database: 269.24.1/1463 - Release Date: 5/23/2008 3:36 PM >>>> >>>> >>>> >>> ------------------------------------------------------------------------- >>> Check out the new SourceForge.net Marketplace. >>> It's the best place to buy or sell services for >>> just about anything Open Source. >>> http://sourceforge.net/services/buy/index.php >>> _______________________________________________ >>> opensipstack-devel mailing list >>> ope...@li... >>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >>> >>> >>> >>> >>> >> >> ------------------------------------------------------------------------- >> Check out the new SourceForge.net Marketplace. >> It's the best place to buy or sell services for >> just about anything Open Source. >> http://sourceforge.net/services/buy/index.php >> _______________________________________________ >> opensipstack-devel mailing list >> ope...@li... >> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >> >> >> > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ > opensipstack-devel mailing list > ope...@li... > https://lists.sourceforge.net/lists/listinfo/opensipstack-devel > > > > |
|
From: Matthias D. <mdr...@gm...> - 2008-06-04 11:59:26
|
Thats the answer I was expecting.:-) Thanks for your answer. jo...@op... schrieb: > it will be a bit of a bad precedent for me to accepts patches to change > function names in the library because of conflicts. I'm sure theora > authors would feel the same. However, theora support seems a good > functionality to add to opensipstack. if you are willing to do that, > then i might consider changing the name ;-) > > Matthias Dreißig wrote: > >> Thanks! >> >> In this context is it possible to contribute a patch where the "quanize" >> functions in q726 codecs files are renamed? We use the theora library >> and there is conflict with a function also called "quantize". >> >> Best Regards >> Matthias >> >> Joegen E. Baclor schrieb: >> >> >>> Hi Matthias, >>> >>> Modified your patches a bit so that PFile::Exists( >>> m_RegRecoveryDIR.c_str() ) will only be performed once within >>> AddRegistrationRecovery(). Your patches are in. >>> >>> Thanks. >>> >>> Joegen >>> >>> jo...@op... wrote: >>> >>> >>> >>>> Hi Matthias, >>>> >>>> I'll take a look. If they dont break anything, I'll commit it in CVS. >>>> I'll let you know. >>>> >>>> Joegen >>>> >>>> Matthias Dreißig wrote: >>>> >>>> >>>> >>>> >>>>> Hello, >>>>> >>>>> I did some changes to OpenSIPStack. Now my question is if it is >>>>> possible to contribute patches? >>>>> >>>>> OpalOSSEndPoint.h.patch: replaced private with protected in >>>>> OpalOSSUserAgent to use derived SessionManager. >>>>> >>>>> RegisterSessionManager.cxx.patch: moved creation of "registry" folder >>>>> to AddRegistrationRecovery(..) so it is only created if really needed. >>>>> >>>>> Regards, >>>>> Matthias >>>>> ------------------------------------------------------------------------ >>>>> >>>>> ------------------------------------------------------------------------- >>>>> Check out the new SourceForge.net Marketplace. >>>>> It's the best place to buy or sell services for >>>>> just about anything Open Source. >>>>> http://sourceforge.net/services/buy/index.php >>>>> ------------------------------------------------------------------------ >>>>> >>>>> _______________________________________________ >>>>> opensipstack-devel mailing list >>>>> ope...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >>>>> ------------------------------------------------------------------------ >>>>> >>>>> Internal Virus Database is out-of-date. >>>>> Checked by AVG. >>>>> Version: 7.5.524 / Virus Database: 269.24.1/1463 - Release Date: 5/23/2008 3:36 PM >>>>> >>>>> >>>>> >>>>> >>>> ------------------------------------------------------------------------- >>>> Check out the new SourceForge.net Marketplace. >>>> It's the best place to buy or sell services for >>>> just about anything Open Source. >>>> http://sourceforge.net/services/buy/index.php >>>> _______________________________________________ >>>> opensipstack-devel mailing list >>>> ope...@li... >>>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >>>> >>>> >>>> >>>> >>>> >>>> >>> ------------------------------------------------------------------------- >>> Check out the new SourceForge.net Marketplace. >>> It's the best place to buy or sell services for >>> just about anything Open Source. >>> http://sourceforge.net/services/buy/index.php >>> _______________________________________________ >>> opensipstack-devel mailing list >>> ope...@li... >>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >>> >>> >>> >>> >> ------------------------------------------------------------------------- >> Check out the new SourceForge.net Marketplace. >> It's the best place to buy or sell services for >> just about anything Open Source. >> http://sourceforge.net/services/buy/index.php >> _______________________________________________ >> opensipstack-devel mailing list >> ope...@li... >> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >> >> >> >> >> > > > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ > opensipstack-devel mailing list > ope...@li... > https://lists.sourceforge.net/lists/listinfo/opensipstack-devel > > |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X