Re: [OpenSIPStack] Correct recognition of a called endpoint video capabilities
Brought to you by:
joegenbaclor
Menu
▾
▴
Re: [OpenSIPStack] Correct recognition of a called endpoint video capabilities
|
From: H.Kropf <mai...@gl...> - 2008-09-01 16:21:42
|
Hi Joegen,
> Can you explain exactly what you
> mean by "the algorithm works incorrectly" ??
O.K.
[OSS endpoint] ==>> INVITE ==>> [Linksys/SPA2102-3.3.6]
[OSS endpoint] <<== 200 OK ("... m=video 0 RTP/AVP 31 ...") <<== [Linksys/SPA2102-3.3.6]
//==================================================
BOOL OpalOSSConnection::OnReceivedSDPMediaDescription(...mediaType == Video...)
{
........
WORD port; /** VC2005 assigns value "4" by default **/
address.GetIpAndPort( ip, port );
.....
}
//==================================================
BOOL OpalInternalIPTransport::GetIpAndPort()
{
......
if (!SplitAddress(address, host, service)) /*** address ==
"tcp$195.21.184.13", host = "195.21.184.13", service == "" ***/
return FALSE;
........
if (service == "*") /*** !!! ignored (service is empty) ***/
port = 0;
else {
if (!service) { /*** !!! ignored (service is empty) ***/
PString proto = address.Left(address.Find('$'));
if (proto *= "ip")
proto = "tcp";
port = PIPSocket::GetPortByService(proto, service);
}
if (port == 0) /*** !!! ignored (port == 4) ***/
{
PTRACE(2, "Opal\tIllegal IP transport port/service: \"" << address
<< '"');
return FALSE;
}
}
........
if (PIPSocket::GetHostAddress(host, ip)) /*** !!! TRUE is returned ***/
return TRUE;
........
}
//==================================================
BOOL OpalOSSConnection::OnReceivedSDPMediaDescription()
{
........
address.GetIpAndPort( ip, port ); /*** !!! port == 4 ***/
if( ip == 0 || port == 0 ) /*** !!! ignored, port == 4 ***/
return TRUE;
.....
}
//==================================================
//==================================================
//==================================================
jo...@op... wrote:
> Ok I commited this in CVS. However I do not see why this is needed
> since address.GetIpAndPort() should always return the media port in the
> SDP m= line and initializing the port to the correct value. Can you
> explain exactly what you mean by "the algorithm works incorrectly" ??
>
>
> H.Kropf wrote:
>
>> Hi Joegen,
>>
>> Implement this change please
>>
>> WORD port = 0;
>>
>> instead of
>>
>> WORD port;
>>
>> in OpalOSSConnection::OnReceivedSDPMediaDescription()
>>
>> Now this variable accepts value 4 by default and the algorithm works
>> incorrectly
>>
>>
>> H.Kropf wrote:
>>
>>
>>> Hi,
>>>
>>> Thanks.
>>>
>>> It will work correctly if to make one more change
>>>
>>>
>>> //====== opalossconnection.cxx ===========
>>>
>>> BOOL OpalOSSConnection::OnReceivedSDPMediaDescription(
>>> SDPSessionDescription & sdp,
>>> SDPMediaDescription::MediaType mediaType,
>>> unsigned rtpSessionId
>>> )
>>> {
>>> ........
>>> PIPSocket::Address ip;
>>> // WORD port;
>>> WORD port = 0;
>>> address.GetIpAndPort( ip, port );
>>> .....
>>> }
>>>
>>> jo...@op... wrote:
>>>
>>>
>>>
>>>> Hi,
>>>>
>>>> I have patched OpalOSSConnection
>>>>
>>>> * $Log: OpalOSSConnection.cxx,v $
>>>> * Revision 1.36 2008/08/24 03:16:05 joegenbaclor
>>>> * Patched OnReceivedSDPMediaDescription not to overwrite
>>>> m_RemoteFormatList and to not
>>>> * create sessions for address or port == 0
>>>>
>>>>
>>>> Can you verify that this patch works?
>>>>
>>>> Joegen
>>>>
>>>>
>>>> H.Kropf wrote:
>>>>
>>>>
>>>>
>>>>
>>>>> Hi,
>>>>>
>>>>> SIP-phone Linksys/SPA2102-3.3.6 announce video capabilities but it don't
>>>>> have they.
>>>>>
>>>>> v=0
>>>>> o=- 3748 3748 IN IP4 193.28.184.99
>>>>> s=-
>>>>> c=IN IP4 193.28.184.13
>>>>> t=0 0
>>>>> m=audio 20224 RTP/AVP 18 101
>>>>> a=rtpmap:18 G729a/8000
>>>>> a=rtpmap:101 telephone-event/8000
>>>>> a=fmtp:101 0-15
>>>>> a=ptime:20
>>>>> a=sendrecv
>>>>> m=video 0 RTP/AVP 31
>>>>> a=nortpproxy:yes
>>>>>
>>>>> Whether it is possible to "learn" OSS to perceive port "0" in string
>>>>> "m=video 0 RTP/AVP 31" as absence of video capabilities?
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> -------------------------------------------------------------------------
>>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>>>> _______________________________________________
>>>>> opensipstack-devel mailing list
>>>>> ope...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel
>>>>>
>>>>>
>>>>> No virus found in this incoming message.
>>>>> Checked by AVG - http://www.avg.com
>>>>> Version: 8.0.138 / Virus Database: 270.6.7/1628 - Release Date: 8/22/2008 6:32 PM
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>> -------------------------------------------------------------------------
>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>>> _______________________________________________
>>>> opensipstack-devel mailing list
>>>> ope...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel
>>>>
>>>>
>>>>
>>>>
>>>>
>>> -------------------------------------------------------------------------
>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>>> Grand prize is a trip for two to an Open Source event anywhere in the world
>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>> _______________________________________________
>>> opensipstack-devel mailing list
>>> ope...@li...
>>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel
>>>
>>>
>>>
>>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> opensipstack-devel mailing list
>> ope...@li...
>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel
>>
>> ------------------------------------------------------------------------
>>
>>
>> No virus found in this incoming message.
>> Checked by AVG - http://www.avg.com
>> Version: 8.0.169 / Virus Database: 270.6.14/1645 - Release Date: 9/1/2008 7:19 AM
>>
>>
>>
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> opensipstack-devel mailing list
> ope...@li...
> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel
>
>
|
