Re: [OpenSIPStack] [OSS] patched VoiceFileChannel

[H.Kropf <mai...@gl...>]

Hi,

It is necessary to correct file  "VoiceFileChannel.h"  .

#ifdef WIN32
// for win32 builds, avoid function name wrong redefinition (PlaySoundA 
or PlaySoundW instead of PlaySound)
#undef PlaySound
#endif

instead of

#ifdef WIN32
#ifdef UNICODE
// avoid function name conflicts for win32 unicode builds
#undef PlaySound
#endif
#endif


Function ms:: PlaySound gets to library OSS either as PlaySoundA or as 
PlaySoundW,
having accepted "#define Playsound" from file VisualStudio/MMSystem.h.
But in it there is no necessity because function ms:: PlaySound has no 
parametres of  type LPCTSTR
and does not require different names for ANSI and UNICODE.
That the program using library OSS, was not mistaken at different 
"character set" IMHO is necessary this patch.




Joegen E. Baclor wrote:
> I haven't tested it but your patch looks ok to me.   This is already in 
> CVS.   Thanks.
>
>  * $Log: VoiceFileChannel.cxx,v $
>  * Revision 1.10  2008/06/04 00:03:18  joegenbaclor
>  * Fixed PlaySound name conflict bug for UNICODE definition - Thanks to 
> helgikropp
>
> H.Kropf wrote:
>   
>> Hello
>>
>> Please substitute the corrected files (in attachments) 
>> VoiceFileChannel.h and VoiceFileChannel.cxx in CVS.
>>
>> This patch resolved PlaySound name conflict for compilation
>> with UNICODE definition.
>> ------------------------------------------------------------------------
>>
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2008.
>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> opensipstack-devel mailing list
>> ope...@li...
>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel
>> ------------------------------------------------------------------------
>>
>> Internal Virus Database is out-of-date.
>> Checked by AVG. 
>> Version: 7.5.524 / Virus Database: 269.24.1/1463 - Release Date: 5/23/2008 3:36 PM
>>     
>
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________
> opensipstack-devel mailing list
> ope...@li...
> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel
>
>