Re: [OpenSIPStack] [SF] RTP fault
Brought to you by:
joegenbaclor
Menu
▾
▴
Re: [OpenSIPStack] [SF] RTP fault
|
From: <jo...@op...> - 2008-06-08 02:59:22
|
Whit and H.Kropf, A leak in OpalFlexiTranscoder proxy class maybe causing this behavior. OpalFlexiTranscoder was first introduced by Ilian Pinzon so that re-invites with a media channel change my allow the codec to be changed in mid session. OpalFlexiTranscoder, however, does not have a destructor override. This allowed the OpalTranscoder object it created in the heap to be forever lost. I have committed a patch for this in CVS and is ready for testing. Let me know if if does/doesn't fix this issue. Thanks. Joegen Joegen E. Baclor wrote: > Ok this bug seems legitimate. I have created a ticket for this in > assembla. > > http://www.assembla.com/spaces/opensbc/tickets/21 . > > If there some more info you could send that might help crush this bug, > please send them in. As a backgrounder, the Voice Age G.729 codec > educational license only allows for one channel to be opened. This is > the reason why OPAL statically flag its usage. Thus, it is very > possible that this bug only became evident with G.729 but may also be > true for other codecs as well. The only diff is other codec might be > more forgiving than G.729. More information that would > confirm/disprove this case, please send them in. > > Thanks > > Joegen > > Whit Thiele wrote: > >> I have also been able to replicate this issue. So far I've only seen it >> happen using G.729. The first call seems to go through, but every subsequent >> call attempt fails. I am going to try recompiling an older snapshot of the >> CVS source I have. >> >> H.Kropf - Have you found out anything new on this issue? >> >> >> Whit >> >> -----Original Message----- >> From: ope...@li... >> [mailto:ope...@li...] On Behalf Of >> Joegen E. Baclor >> Sent: Thursday, May 22, 2008 9:14 PM >> To: H.Kropf >> Cc: ope...@li... >> Subject: Re: [OpenSIPStack] [SF] RTP fault >> >> Hi, >> >> Thanks for the logs. They were very helpful. It is evident that the >> previous call did not destroy the codec properly. I will try to >> replicate this on my system. Ilian is currently on leave so it might >> take a while for him to catch this thread. I have created a ticket for >> this: http://www.assembla.com/spaces/opensbc/tickets/20 >> >> Joegen >> >> H.Kropf wrote: >> >> >>> Hi >>> >>> Log (for pwlib - level 6) - in attachments >>> >>> >>> Joegen E. Baclor wrote: >>> >>> >>>> Hmmn. Strange. Seems like the codec from the previous call has not >>>> been destroyed. Can you send me a maximum level log of two >>>> consecutive calls right after fresh startup of your SoftPhone? >>>> >>>> H.Kropf wrote: >>>> >>>> >>>> >>>>> Hi >>>>> >>>>> >>>>> >>>>> >>>>>>> can you put a break-point in OpalTranscoder::ConvertFrames() and >>>>>>> figure out where exactly it fails? >>>>>>> >>>>>>> >>>>>>> >>>>> I can :) >>>>> >>>>> >>>>> bool OpalMediaPatch::Sink::WriteFrame(RTP_DataFrame & sourceFrame) >>>>> { >>>>> ...... >>>>> if (!primaryCodec->ConvertFrames(sourceFrame, intermediateFrames)) >>>>> { >>>>> PTRACE(1, "Patch\tMedia conversion (primary) failed"); >>>>> return false; >>>>> } >>>>> ...... >>>>> } >>>>> >>>>> BOOL OpalTranscoder::ConvertFrames(const RTP_DataFrame & input, >>>>> RTP_DataFrameList & output) >>>>> { >>>>> ....... >>>>> return Convert(input, output[0]); >>>>> } >>>>> >>>>> BOOL OpalFlexiTranscoder::Convert( const RTP_DataFrame & input, >>>>> RTP_DataFrame & output) >>>>> { >>>>> return m_Transcoder->Convert( input, output ); >>>>> } >>>>> >>>>> BOOL OpalFramedTranscoder::Convert(const RTP_DataFrame & input, >>>>> RTP_DataFrame & output) >>>>> { >>>>> .... >>>>> while (inputLength > 0) >>>>> { >>>>> ...... >>>>> if (!ConvertFrame(inputPtr, consumed, outputPtr, created)) >>>>> return FALSE; >>>>> ....... >>>>> } >>>>> ....... >>>>> } >>>>> >>>>> BOOL OpalFramedTranscoder::ConvertFrame(const BYTE * inputPtr, >>>>> PINDEX & /*consumed*/, BYTE * outputPtr, PINDEX & /*created*/) >>>>> { >>>>> return ConvertFrame(inputPtr, outputPtr); >>>>> } >>>>> >>>>> >>>>> >>>>> BOOL Opal_PCM_G729::ConvertFrame(const BYTE * src, BYTE * dst) >>>>> { >>>>> if (voiceAgeEncoderInUse != this) return FALSE; // >>>>> !!!!!!!!!!!! <<<=== this place >>>>> ...... >>>>> } >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>>> Hi, >>>>>> >>>>>> Are you a C++ developer? If so, can you put a break-point in >>>>>> OpalTranscoder::ConvertFrames() and figure out where exactly it fails? >>>>>> >>>>>> Joegen >>>>>> >>>>>> H.Kropf wrote: >>>>>> >>>>>> >>>>>> >>>>>>> Hello >>>>>>> >>>>>>> After a last update of library from CVS (2008-05-20), my softphone >>>>>>> (on OSS library) makes only one successful call after start. In >>>>>>> next calls there is no voice. In PTRACE-log there are many such >>>>>>> records >>>>>>> >>>>>>> Media Patch:1eb9410 PWL: [CID=0x0000] Patch Media conversion >>>>>>> (primary) failed >>>>>>> Media Patch:1eb9410 PWL: [CID=0x0000] Patch Media conversion >>>>>>> (primary) failed >>>>>>> Media Patch:1eb9410 PWL: [CID=0x0000] Patch Media conversion >>>>>>> (primary) failed >>>>>>> Media Patch:1eb9410 PWL: [CID=0x0000] Patch Media conversion >>>>>>> (primary) failed >>>>>>> >>>>>>> >>>>>>> In the previous version (CVS 2008-05-12) this problem did not exist >>>>>>> >>>>>>> >>>>>>> >>>>>>> >> ------------------------------------------------------------------------- >> >> >>>>>>> This SF.net email is sponsored by: Microsoft Defy all challenges. >>>>>>> Microsoft(R) Visual Studio 2008. >>>>>>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >>>>>>> _______________________________________________ >>>>>>> opensipstack-devel mailing list >>>>>>> ope...@li... >>>>>>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >> ------------------------------------------------------------------------- >> >> >>>>>> This SF.net email is sponsored by: Microsoft Defy all challenges. >>>>>> Microsoft(R) Visual Studio 2008. >>>>>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >>>>>> _______________________________________________ >>>>>> opensipstack-devel mailing list >>>>>> ope...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >>>>>> >>>>>> >>>>>> >>>>>> >> ------------------------------------------------------------------------- >> >> >>>>> This SF.net email is sponsored by: Microsoft Defy all challenges. >>>>> Microsoft(R) Visual Studio 2008. >>>>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >>>>> _______________________________________________ >>>>> opensipstack-devel mailing list >>>>> ope...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >>>>> >>>>> >>>>> >>>>> >>>>> >>>> ------------------------------------------------------------------------- >>>> >>>> >> >> >>>> This SF.net email is sponsored by: Microsoft Defy all challenges. >>>> Microsoft(R) Visual Studio 2008. >>>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >>>> _______________________________________________ >>>> opensipstack-devel mailing list >>>> ope...@li... >>>> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >>>> >>>> >>>> >>>> >>> ------------------------------------------------------------------------ >>> >>> No virus found in this incoming message. >>> Checked by AVG. >>> Version: 7.5.524 / Virus Database: 269.23.21/1458 - Release Date: >>> >>> >> 5/21/2008 7:21 AM >> >> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by: Microsoft >> Defy all challenges. Microsoft(R) Visual Studio 2008. >> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >> _______________________________________________ >> opensipstack-devel mailing list >> ope...@li... >> https://lists.sourceforge.net/lists/listinfo/opensipstack-devel >> >> No virus found in this incoming message. >> Checked by AVG. >> Version: 8.0.100 / Virus Database: 269.23.21/1458 - Release Date: 5/21/2008 >> 7:21 AM >> >> >> >> >> > > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ > opensipstack-devel mailing list > ope...@li... > https://lists.sourceforge.net/lists/listinfo/opensipstack-devel > > > > |
