#247 NATHELPER and OPTIONS ping for tcp proto

1.8.x
closed-accepted
modules (179)
5
2013-01-23
2012-10-26
No

nathelper don't want to ping abonents with TCP transport.

Here is a small patch:

Index: modules/nathelper/nathelper.c

--- modules/nathelper/nathelper.c (revision 9391)
+++ modules/nathelper/nathelper.c (working copy)
@@ -1228,8 +1228,6 @@
continue;
}
}
- if (curi.proto != PROTO_UDP && curi.proto != PROTO_NONE)
- continue;
if (curi.port_no == 0)
curi.port_no = SIP_PORT;
proto = curi.proto;

Discussion

  • Nick Altmann

    Nick Altmann - 2012-10-29

    I think you disable OPTIONS because we can use tcp keepalives. But sometimes we need exactly OPTIONS pings via tcp protocol. I suggest to add a module option to enable/disable OPTIONS pings via tcp.

     
  • Nick Altmann

    Nick Altmann - 2012-10-30

    Uploaded patch to add sipping_tcp option.

     
  • Vladut-Stefan Paiu

    • labels: 1134770 --> modules
    • milestone: 2722453 --> 1.8.x
     
  • Vladut-Stefan Paiu

    Hello,

    Seems a little dangerous to start ping-ing TCP clients with Options. First thing that would need to be added is the tcp_no_new_conn_bflag , in order not to open a new connection if the old one is down.

    But still, couldn't we just use the tcp_keepalive param ( see [1] ) ?

    Can you give some examples of cases where you need explicit SIP Option pings over TCP ?

    [1] http://www.opensips.org/Resources/DocsCoreFcn18#toc84

    Regards,
    Vlad

     
  • Bogdan-Andrei Iancu

    • assigned_to: nobody --> liviuchircu
     
  • Bogdan-Andrei Iancu

    Your patch was not correct as even if you were allowing pinging for TCP contacts too, the pinging was still done via UDP.

    Liviu added a new parameter to control when to do TCP pinging:
    , see http://www.opensips.org/Main/Ver190#toc13 .

    Regards,
    Bogdan

     
  • Bogdan-Andrei Iancu

    • status: open --> closed-accepted
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks