Menu ▾ ▴

#244 [acc] Failure Route Changes

1.8.x
open-invalid
Bogdan-Andrei Iancu
modules (179)
5
2013-01-28
2012-09-07
David Sanders
No

At the moment the ACC module will log a failed call after any set onreply_route, but before a failure_route.

The attached patch is a simple change to the TM callback registered for by on_missed so that the callback fires after the failure_route, allowing any changes made in the failure_route to show up in the logged call.

Patch has been tested and worked as expected, however, I'm not positive that I haven't overlooked some other side-effect of the change.

Discussion

  • David Sanders

    David Sanders - 2012-09-07
     
    failure_route_acc.patch

  • Bogdan-Andrei Iancu

    Bogdan-Andrei Iancu - 2013-01-22
    • assigned_to: nobody --> bogdan_iancu
     

  • Bogdan-Andrei Iancu

    Bogdan-Andrei Iancu - 2013-01-28

    Hi David,

    There is something weird in the patch :
    1) you changed from TMCB_ON_FAILURE to TMCB_ON_FAILURE_RO only in the callback function, but not where callback is registered too.
    2) the TMCB_ON_FAILURE_RO callback is obsoleted in TM and never trigger ..

    Are you sure you attached the right patch ?

    Regards,
    Bogdan

     

  • Bogdan-Andrei Iancu

    Bogdan-Andrei Iancu - 2013-01-28
    • status: open --> open-invalid
     

  • David Sanders

    David Sanders - 2013-01-28

    Hi Bogdan,

    Strange...this patch does look wrong. However, it was long enough ago that I don't remember my thought process. :)

    Seemed to work at the time, although now I don't know how that's possible.

    Can you remove TMCB_ON_FAILURE_RO from t_hooks.h/c since it is obsolete?

    - David

     

Log in to post a comment.