Menu ▾ ▴

#182 Call Control does not properly handle custom init/start/stop

1.5.x
open
saghul
modules (179)
5
2013-05-27
2011-02-26
Dynamic Packet
No

When using custom init/start/stop messages, no command word or default params are sent over. This results in loosing part of the call information which is unavailable to the AVP set, such as dialogid.

Also the issue for the format, for default messages, a certain format is used, custom, completely different. It seems like these custom messages were overlooked in the original code perhaps because no one used them. Attached is the patch that corrects this behavior. Custom AVP's should be IN ADDITION to the standard message AND in the SAME FORMAT, without loosing dialogid.

Below is an example of a default start message and then a custom one before the patch.

Default START MESSAGE example:
start
callid: 9xNQjtR8M7Q1jI8U960DPvVXWgBoyzNt
dialogid: 3838:1383587848

Custom START MESSAGE example (BEFORE PATCH):
from = sip:test5@sip.domain.com to = sip:18885233456@sip.domain.com callid = 9xNQjtR8M7Q1jI8U960DPvVXWgBoyzNt

Custom START MESSAGE example (AFTER PATCH):
start
callid: 9xNQjtR8M7Q1jI8U960DPvVXWgBoyzNt
dialogid: 3838:1383587848
from: sip:test5@sip.domain.com
to: sip:18885233456@sip.domain.com

Discussion

  • Dynamic Packet

    Dynamic Packet - 2011-02-26

    Call control custom message patch

     
    opensips_163_callcontrol.patch

  • Dynamic Packet

    Dynamic Packet - 2011-02-28
    • assigned_to: nobody --> dan_pascu
     

  • Everson Pereira

    Everson Pereira - 2013-05-27

    Opensips 1.8.x patch

     
    patch_callcontrol

  • Bogdan-Andrei Iancu

    Bogdan-Andrei Iancu - 2013-05-27
    • assigned_to: Dan Pascu --> saghul
    • Group: --> 1.5.x
     

Log in to post a comment.