#422 backport of more missing free_to_params

1.6.x
closed-fixed
modules (454)
5
2011-09-30
2011-09-19
No

Hi,

in this report I mention that a couple of times free_to_params is not called:
https://sourceforge.net/tracker/?func=detail&aid=3411434&group_id=232389&atid=1086410

After backporting those changes to 1.6, there are a couple of changes that had already been done, but haven't been backported.

Attached, a patch that fixes a couple of those. (I skipped fixing these modules, because I don't use them: rls, pua_xmpp, b2b_entities, msilo. They could use some fixing as well.)

Regards,
Walter Doekes
OSSO B.V.

Some issues had already been fixed in trunk. Attached is an additional patch against the 1.6 branch of the items that

Discussion

  • Bogdan-Andrei Iancu

    • assigned_to: nobody --> vladut-paiu
     
  • Walter Doekes

    Walter Doekes - 2011-09-26

    All brokenness has been fixed in a different manner. parse_to() shouldn't have been called this often. This is fixed in 1.7 and trunk by calling the message parser instead.

    But.. those changes won't be backported to 1.6. That means that it would be safe to commit my patch to 1.6 as a bugfix of that branch only. Right?

    (P.S. I found no unfixed issues of this type in trunk, so that's good.)

     
  • Vladut-Stefan Paiu

    Hello,

    Yes, indeed, as we have talked on IRC, in trunk and in 1.7 this issue was fixed in a proper way, by not having parse_to called unnecessarily.
    I have applied this patch as is in the 1.6 branch.

    Thanks and regards,
    Vlad

     
  • Vladut-Stefan Paiu

    • status: open --> closed
     
  • Vladut-Stefan Paiu

    • status: closed --> closed-fixed
     

Log in to post a comment.