From: Carsten N. <car...@gm...> - 2011-11-28 17:10:40
|
Hi Gerrit, On 11/27/2011 11:46 PM, Gerrit Voss wrote: > - Log ----------------------------------------------------------------- > commitdiff: http://opensg.git.sourceforge.net/git/gitweb.cgi?p=opensg/opensg;a=commitdiff;h=f888cfda28ab6088438ece86f278ad906dd4e848 > commit f888cfda28ab6088438ece86f278ad906dd4e848 > Author: gerrit<vo...@vo...> > Date: Mon Nov 28 13:44:00 2011 +0800 > > changed: make rendering backend independent of viewport->window parent link > renamed viewport/camera functions that rely on this link to computeXXX > I know it's a bike-shedding thing, but there is some precedent for calling functions like that calcXXX (e.g. Image::calcIsAlphaBinary() or Camera::calcViewRay()) [1]. Did you deliberately pick a different prefix? If not would you object if I changed it? Cheers, Carsten [1] If we keep computeXXX, we should probably make it Camera::computeViewRay(), it kinda sticks out now ;) |