Re: [Opensg-core] Make Node::_sfVolume non-internal field?

[Carsten N. <car...@gm...>]

	Hello Gerrit,

On 07/03/2011 09:45 PM, Gerrit Voß wrote:
> ok, I committed your old change origin patch,

ok, thanks, especially for catching this:

// I don't think clear is correct here if the apps expects to tap
// into the changes they will be gone (GV)
//pDstCL->commitChangesAndClear(ChangedOrigin::Sync);

I agree, clear is not the right thing to do here.

> for the map in
> shaderprogvars I fixed it so it behaves the same as the local
> MT sync an rebuilds the map if the var fields are changed during
> a sync. I also pushed the map down to ShaderProgramVariables and
> removed the access class as ShaderProgramVariables has taken over
> that part anyway so there should be no need for a separate class
> anymore.

ok, I had mostly kept it separate so that there is a type that can be 
put in a SField and synced across the cluster.

> I did some basic testing and it looks ok, the values are
> updated and no warnings are printed.

a quick test here seems to confirm this, I also don't get the warnings 
any more.

	Thanks & cheers,
		Carsten