Re: [Opensg-core] Make Node::_sfVolume non-internal field?

[Gerrit V. <vo...@vo...>]

Hi,

On Sun, 2011-07-03 at 08:59 +0800, Gerrit Voß wrote:
> Hi,
> 
> On Fri, 2011-07-01 at 12:35 -0500, Carsten Neumann wrote:
> > 	Hello all,
> > 
> > I'd like to make Node::_sfVolume a non-internal field and modify the OSB 
> > loader/writer to write it out in certain cases (see attached patch).
> > 
> > If a volume is marked as static or infinite, written to OSB and read 
> > back in that information is lost. I see this when loading from OGRE 
> > .mesh files (which can contain an explicit volume in case the mesh is 
> > animated to contain all motions the mesh goes through) storing to OSB 
> > and loading that back in.
> > 
> > Luckily the OSB format is robust enough that we don't have to bump the 
> > version number - old versions of OpenSG load OSBs written by ones with 
> > the patch applied and the other way around.
> > 
> > Any objections/comments?
> 
> looks ok to me, I'm just going to your old patches (changed
> origin / shader var). For the shaders I have to have a deeper
> look there is something odd already without you patchset which
> I want to fix first.

ok, I committed your old change origin patch, for the map in 
shaderprogvars I fixed it so it behaves the same as the local
MT sync an rebuilds the map if the var fields are changed during
a sync. I also pushed the map down to ShaderProgramVariables and
removed the access class as ShaderProgramVariables has taken over
that part anyway so there should be no need for a separate class
anymore.

I did some basic testing and it looks ok, the values are
updated and no warnings are printed.

kind regards
  gerrit