[Opensc-commits] [OpenSC/OpenSC] 24eddb: pkcs11-tool: Add id/slot-id to PKCS#11 URIs

[Sergio A. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 24eddbf9a9a167184245123ce66797c76acc9f14
      https://github.com/OpenSC/OpenSC/commit/24eddbf9a9a167184245123ce66797c76acc9f14
  Author: Sergio Arroutbi <sar...@re...>
  Date:   2025-11-06 (Thu, 06 Nov 2025)

  Changed paths:
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  pkcs11-tool: Add id/slot-id to PKCS#11 URIs

Extend pkcs11-tool to include additional identifier parameters in PKCS#11 URIs
to improve object and token identification:

For -L option (list slots):
- Add slot-id parameter to token URIs to identify specific slots
- Before: pkcs11:model=PKCS%2315%20emulated;manufacturer=piv_II;serial=84914bc36f04a55d;token=clevis
- After:  pkcs11:model=PKCS%2315%20emulated;manufacturer=piv_II;serial=84914bc36f04a55d;token=clevis;slot-id=0

For -O option (list objects):
- Add id parameter to data object URIs when CKA_ID attribute is available
- Previously only keys and certificates included id parameters
- Data objects now consistently show id parameters using getID() function

Changes made:
1. Created get_uri_with_slot() function to generate token URIs with slot-id parameter
2. Modified show_token() to use new URI generation function with slot identification
3. Enhanced show_dobj() to retrieve and include object IDs for data objects
4. Added proper ID handling using existing getID() function for PKCS#11 objects

The implementation correctly distinguishes between:
- Token identifiers: slot-id parameter for slot/token identification
- Object identifiers: id parameter from CKA_ID attribute for PKCS#11 objects

Co-Authored-By: Claude <no...@an...>
Signed-off-by: Sergio Arroutbi <sar...@re...>


  Commit: e54dcb153a37cb4ba7f2ff8a00dd1b0b527300db
      https://github.com/OpenSC/OpenSC/commit/e54dcb153a37cb4ba7f2ff8a00dd1b0b527300db
  Author: Sergio Arroutbi <sar...@re...>
  Date:   2025-11-06 (Thu, 06 Nov 2025)

  Changed paths:
    M doc/tools/pkcs11-tool.1.xml
    M doc/tools/tools.html
    M src/tools/pkcs11-tool.c
    M tests/Makefile.am
    A tests/test-pkcs11-tool-uri-with-slot-id.sh

  Log Message:
  -----------
  Add --uri-with-slot-id option to show slot-id

Co-Authored-By: Claude <no...@an...>
Signed-off-by: Sergio Arroutbi <sar...@re...>


  Commit: 25a394a8a8084ae203438f6d3b0fd7ed54eed5da
      https://github.com/OpenSC/OpenSC/commit/25a394a8a8084ae203438f6d3b0fd7ed54eed5da
  Author: Sergio Arroutbi <sar...@re...>
  Date:   2025-11-06 (Thu, 06 Nov 2025)

  Changed paths:
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  Refactor code and use get_uri to avoid duplication

Signed-off-by: Sergio Arroutbi <sar...@re...>


  Commit: 72a4c842c6740e24cf82520e9bb98648f9d631a4
      https://github.com/OpenSC/OpenSC/commit/72a4c842c6740e24cf82520e9bb98648f9d631a4
  Author: Sergio Arroutbi <sar...@re...>
  Date:   2025-11-06 (Thu, 06 Nov 2025)

  Changed paths:
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  Update src/tools/pkcs11-tool.c

Co-authored-by: Jakub Jelen <ja...@gm...>
Signed-off-by: Sergio Arroutbi <sar...@re...>


  Commit: b538efb703cb99b87beb4663acd907b8bd0fadf0
      https://github.com/OpenSC/OpenSC/commit/b538efb703cb99b87beb4663acd907b8bd0fadf0
  Author: Sergio Arroutbi <sar...@re...>
  Date:   2025-11-06 (Thu, 06 Nov 2025)

  Changed paths:
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  Data objects do not have the CKA_ID attribute

It can not be enured CKA_ID is appropriately set
in all the cases. Removing it from uri to avoid
false errors/warnings on compliant implementations

Co-authored-by: Jakub Jelen <ja...@gm...>
Signed-off-by: Sergio Arroutbi <sar...@re...>


Compare: https://github.com/OpenSC/OpenSC/compare/cc516a6c8fb0...b538efb703cb

To unsubscribe from these emails, change your notification settings at https://github.com/OpenSC/OpenSC/settings/notifications