[Opensc-commits] [OpenSC/OpenSC] 781568: piv: Fix possible integer truncation/overflow

[Jakub J. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 781568f6479e4a8127c7ed53f92e098bcd347146
      https://github.com/OpenSC/OpenSC/commit/781568f6479e4a8127c7ed53f92e098bcd347146
  Author: Jakub Jelen <jj...@re...>
  Date:   2025-06-14 (Sat, 14 Jun 2025)

  Changed paths:
    M src/libopensc/card-piv.c

  Log Message:
  -----------
  piv: Fix possible integer truncation/overflow

When negative value is returned from sc_asn1_put_tag(), it is first assigned to
`sbuflen`, which is unsigned, truncating the negative numbers.
Only after that assigned to the `r`, causing it can't be negative, effectively
hiding possible errors from the above function.

Thanks coverity (CID 468028)

Signed-off-by: Jakub Jelen <jj...@re...>


  Commit: bffa8d2fe30e19dad7e5ee65edf2dddaa3f45d1a
      https://github.com/OpenSC/OpenSC/commit/bffa8d2fe30e19dad7e5ee65edf2dddaa3f45d1a
  Author: Jakub Jelen <jj...@re...>
  Date:   2025-06-14 (Sat, 14 Jun 2025)

  Changed paths:
    M src/libopensc/pkcs15-coolkey.c

  Log Message:
  -----------
  coolkey: Avoid memory leak when reading certificate

The certificate is read from the CKA_VALUE, which is allocated in `data` field of
`sc_pkcs15_der` structure of the `sc_pkcs15_cert_info`. This is processed, but
never cleaned up.

Thanks coverity (CID 454833, CID 454822)

Signed-off-by: Jakub Jelen <jj...@re...>


  Commit: e4eaa2af96867ae256636b075c7fba17f5d37250
      https://github.com/OpenSC/OpenSC/commit/e4eaa2af96867ae256636b075c7fba17f5d37250
  Author: Jakub Jelen <jj...@re...>
  Date:   2025-06-14 (Sat, 14 Jun 2025)

  Changed paths:
    M src/libopensc/iasecc-sm.c

  Log Message:
  -----------
  iasecc: Avoid dereference before NULL check

Thanks coverity (CID 13754)

Signed-off-by: Jakub Jelen <jj...@re...>


Compare: https://github.com/OpenSC/OpenSC/compare/a1375a5cdf6b...e4eaa2af9686

To unsubscribe from these emails, change your notification settings at https://github.com/OpenSC/OpenSC/settings/notifications