[Opensc-commits] [OpenSC/OpenSC] 990fe6: src/libopensc/card-*.c: remove bMatch assignment t...

[Jakub J. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 990fe6dc3f64eab5b8bf381949ade22765cb1043
      https://github.com/OpenSC/OpenSC/commit/990fe6dc3f64eab5b8bf381949ade22765cb1043
  Author: Gianfranco Costamagna <loc...@de...>
  Date:   2025-01-22 (Wed, 22 Jan 2025)

  Changed paths:
    M src/libopensc/card-atrust-acos.c
    M src/libopensc/card-entersafe.c
    M src/libopensc/card-epass2003.c

  Log Message:
  -----------
  src/libopensc/card-*.c: remove bMatch assignment to avoid confusion

>From  Jakub Jelen <ja...@gm...>

on line 437 we assert the pathlen is 2 or 4 or 6
on line 440 we assert that if pathlen is 6, the first two bytes are 0x3F00
on line 444 we extend the 2 or 4 bytes paths to 4 or 6 bytes starting with 0x3F00
the line 459 is no-operation with your change. It should be removed if it keeps working as it should
This line change semantics as previously we were heading here also when we had a cache, but first two bytes of path did not match. OTOH I think this should never happen as the path should always start with 0x3F00 so I believe this change is ok.

Just remove the line 459 to avoid confusion. Same in the other files, where similar construct exist.

https://github.com/OpenSC/OpenSC/pull/3299/files#r1899506106



To unsubscribe from these emails, change your notification settings at https://github.com/OpenSC/OpenSC/settings/notifications