[Opensc-commits] [OpenSC/OpenSC] 643d4c: From: Doug Engert:

[Veronika H. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 643d4c1a0c8faf85341d099d5197f5a984020fcc
      https://github.com/OpenSC/OpenSC/commit/643d4c1a0c8faf85341d099d5197f5a984020fcc
  Author: Gianfranco Costamagna <loc...@de...>
  Date:   2025-01-14 (Tue, 14 Jan 2025)

  Changed paths:
    M src/libopensc/card-atrust-acos.c
    M src/libopensc/card-entersafe.c
    M src/libopensc/card-epass2003.c

  Log Message:
  -----------
  From:  Doug Engert:
convert int bMatch = -1 into size_t bMatch = 0, this fixes errors such as:
card-entersafe.c: In function ‘entersafe_select_file’:
card-entersafe.c:649:28: error: ‘__memcpy_chk’ writing between 18446744073709551608 and 18446744073709551613 bytes into a region of size 64 [-Werror=stringop-overflow=]
  649 |                            memcpy(new_path.value, &(path[bMatch+2]), new_path.len);
      |                            ^
card-entersafe.c:639:38: note: destination object ‘new_path’ of size 64
  639 |                            sc_path_t new_path;
      |                                      ^~~~~~~~
/bin/bash ../../libtool  --tag=CC --tag CC  --mode=compile gcc -DHAVE_CONFIG_H -I. -I../..  -D'OPENSC_CONF_PATH="/etc/opensc/opensc.conf"' -D'DEFAULT_SM_MODULE_PATH="/usr/lib/powerpc64le-linux-gnu"' -D'DEFAULT_SM_MODULE="libsmm-local.so"' -I../../src -Wdate-time -D_FORTIFY_SOURCE=3    -I/usr/include/PCSC   -Wall -Wextra -Wno-unused-parameter -Werror -Wstrict-aliasing=2 -g -O3 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -fno-stack-clash-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/opensc-0.25.1-2 -Wno-error=maybe-uninitialized -c -o libopensc_la-card-coolkey.lo `test -f 'card-coolkey.c' || echo './'`card-coolkey.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -DOPENSC_CONF_PATH=\"/etc/opensc/opensc.conf\" -DDEFAULT_SM_MODULE_PATH=\"/usr/lib/powerpc64le-linux-gnu\" -DDEFAULT_SM_MODULE=\"libsmm-local.so\" -I../../src -Wdate-time -D_FORTIFY_SOURCE=3 -I/usr/include/PCSC -Wall -Wextra -Wno-unused-parameter -Werror -Wstrict-aliasing=2 -g -O3 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -fno-stack-clash-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/opensc-0.25.1-2 -Wno-error=maybe-uninitialized -c card-coolkey.c  -fPIC -DPIC -o .libs/libopensc_la-card-coolkey.o
cc1: all warnings being treated as errors
make[4]: *** [Makefile:1756: libopensc_la-card-entersafe.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -DOPENSC_CONF_PATH=\"/etc/opensc/opensc.conf\" -DDEFAULT_SM_MODULE_PATH=\"/usr/lib/powerpc64le-linux-gnu\" -DDEFAULT_SM_MODULE=\"libsmm-local.so\" -I../../src -Wdate-time -D_FORTIFY_SOURCE=3 -I/usr/include/PCSC -Wall -Wextra -Wno-unused-parameter -Werror -Wstrict-aliasing=2 -g -O3 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -fno-stack-clash-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/opensc-0.25.1-2 -Wno-error=maybe-uninitialized -c card-coolkey.c -o libopensc_la-card-coolkey.o >/dev/null 2>&1
In file included from /usr/include/string.h:548,
                 from card-epass2003.c:30:
In function ‘memcpy’,
    inlined from ‘epass2003_select_path’ at card-epass2003.c:2080:4,
    inlined from ‘epass2003_select_file’ at card-epass2003.c:2148:10:
/usr/include/powerpc64le-linux-gnu/bits/string_fortified.h:29:10: error: ‘__memcpy_chk’ specified bound between 18446744073709551608 and 18446744073709551613 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]
   29 |   return __builtin___memcpy_chk (__dest, __src, __len,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   30 |                                  __glibc_objsize0 (__dest));
      |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[4]: *** [Makefile:1763: libopensc_la-card-epass2003.lo] Error 1
make[4]: Leaving directory '/<<PKGBUILDDIR>>/src/libopensc'
make[3]: *** [Makefile:483: all-recursive] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:626: all-recursive] Error 1

Fix: #3243



To unsubscribe from these emails, change your notification settings at https://github.com/OpenSC/OpenSC/settings/notifications