[Opensc-commits] [OpenSC/OpenSC] 8f1530: Use 'BYTES4BITS' in all OpenSC code

[Doug E. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 8f15301afd648ec47239d68ea61598d9c5972a1e
      https://github.com/OpenSC/OpenSC/commit/8f15301afd648ec47239d68ea61598d9c5972a1e
  Author: Doug Engert <dee...@gm...>
  Date:   2024-11-22 (Fri, 22 Nov 2024)

  Changed paths:
    M src/libopensc/asn1.c
    M src/libopensc/card-eoi.c
    M src/libopensc/card-isoApplet.c
    M src/libopensc/card-myeid.c
    M src/libopensc/card-piv.c
    M src/libopensc/card-setcos.c
    M src/libopensc/padding.c
    M src/libopensc/pkcs15-prkey.c
    M src/libopensc/pkcs15-pubkey.c
    M src/libopensc/pkcs15-sec.c
    M src/pkcs11/mechanism.c
    M src/pkcs15init/pkcs15-isoApplet.c
    M src/pkcs15init/pkcs15-myeid.c
    M src/pkcs15init/pkcs15-setcos.c
    M src/tests/fuzzing/fuzz_pkcs15init.c
    M src/tests/p11test/p11test_case_ec_derive.c
    M src/tests/p11test/p11test_case_ec_sign.c
    M src/tests/p11test/p11test_case_pss_oaep.c
    M src/tests/p11test/p11test_case_readonly.c
    M src/tools/pkcs11-tool.c
    M src/tools/pkcs15-init.c

  Log Message:
  -----------
  Use 'BYTES4BITS' in all OpenSC code

'BYTES4BITS' is defined in 'libopensc/internal.c'

As suggested,in https://github.com/OpenSC/OpenSC/pull/3090#issuecomment-2459547719

All places in OpenSC that need to get number of bytes needed to hold some data bits
i.e. 'bytes = (bits + 7) / 8;' will now use 'bytes = BYTES4BITS(bits);'

`#include "libopensc/internal.h"' was added to 7 of these files.

This command was used to find the lines which needed to be changed:
find . -type d -name .svn -prune , -name .git -prune , -type f -name \*.c -exec \
    grep -E -n -e '[(].*+[[:blank:]]?7[[:blank:]]?[)]?[[:blank:]]?[/][[:blank:]]?8' {} \; -print

There are two other files that use 'Y = (X + 7) / 8;' but these are to
alloc multiples of 8 bytes for SM padding bytes. These where not changed.

 On branch BYTES4BITS
 Changes to be committed:
	modified:   src/libopensc/asn1.c
	modified:   src/libopensc/card-eoi.c
	modified:   src/libopensc/card-isoApplet.c
	modified:   src/libopensc/card-myeid.c
	modified:   src/libopensc/card-piv.c
	modified:   src/libopensc/card-setcos.c
	modified:   src/libopensc/padding.c
	modified:   src/libopensc/pkcs15-prkey.c
	modified:   src/libopensc/pkcs15-pubkey.c
	modified:   src/libopensc/pkcs15-sec.c
	modified:   src/pkcs11/mechanism.c
	modified:   src/pkcs15init/pkcs15-isoApplet.c
	modified:   src/pkcs15init/pkcs15-myeid.c
	modified:   src/pkcs15init/pkcs15-setcos.c
	modified:   src/tests/fuzzing/fuzz_pkcs15init.c
	modified:   src/tests/p11test/p11test_case_ec_derive.c
	modified:   src/tests/p11test/p11test_case_ec_sign.c
	modified:   src/tests/p11test/p11test_case_pss_oaep.c
	modified:   src/tests/p11test/p11test_case_readonly.c
	modified:   src/tools/pkcs11-tool.c
	modified:   src/tools/pkcs15-init.c



To unsubscribe from these emails, change your notification settings at https://github.com/OpenSC/OpenSC/settings/notifications