[Opensc-commits] [OpenSC/OpenSC] 8d0474: pkcs15-jpki.c - minidriver problem with reading p...

[Doug E. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 8d04748704f24da97dd98b66c2fcd7f718eb8b4a
      https://github.com/OpenSC/OpenSC/commit/8d04748704f24da97dd98b66c2fcd7f718eb8b4a
  Author: Doug Engert <dee...@gm...>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M src/libopensc/pkcs15-jpki.c

  Log Message:
  -----------
  pkcs15-jpki.c -  minidriver problem with reading public key

Add SC_PKCS15_CO_FLAG_PRIVATE on "Digital Signature Public Key" and
set pubkey_obj.flags and pubkey_obj.auth_id to use the Sign KEY
so minidriver.c can request the pin before reading the public key.
Card enforces this as perspecs.

Partial fix for #3169 Only pkcs15-jpki.c is changed.

In addition to changes in #3167 that address "user_consent" using
"PinCacheAlwaysPrompt", The JPKI card forces the user to verify the Sign PIN
before the public key is read. But to use the Sign KEY,
Windows minidriver specs V7.07 says: the "CCP_CONTAINER_INFO"
contains "cbSigPublicKey" and "pbSigPublicKey"
which is needed before the key is selected.

It might be possible to add bogus information in these and
substitute the real values at a later time. But this will require
someone with a working card.

 On branch minidriver-PinCacheAlwaysPrompt
 Changes to be committed:
	modified:   libopensc/pkcs15-jpki.c

 On branch JPKI-Improvments
 Changes to be committed:
	modified:   libopensc/pkcs15-jpki.c


  Commit: 9dc4e11325280dc1356ae5ffb3a8fd598cb591b9
      https://github.com/OpenSC/OpenSC/commit/9dc4e11325280dc1356ae5ffb3a8fd598cb591b9
  Author: Doug Engert <dee...@gm...>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M src/libopensc/pkcs15-jpki.c

  Log Message:
  -----------
  pkcs15-jpki.c - code format change

Suggesed by clang-format-lint

 On branch JPKI-Improvements
 Changes to be committed:
	modified:   libopensc/pkcs15-jpki.c


Compare: https://github.com/OpenSC/OpenSC/compare/21ba386091b6...9dc4e1132528

To unsubscribe from these emails, change your notification settings at https://github.com/OpenSC/OpenSC/settings/notifications