[Opensc-commits] [OpenSC/OpenSC] 0ba15b: Check SW2 when SW1 is 0x90

[Veronika H. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 0ba15ba096b9cd58354cf8960e04f295af3de59c
      https://github.com/OpenSC/OpenSC/commit/0ba15ba096b9cd58354cf8960e04f295af3de59c
  Author: Veronika Hanulíková <vha...@re...>
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
    M src/libopensc/card-atrust-acos.c
    M src/libopensc/card-starcos.c
    M src/libopensc/iso7816.c

  Log Message:
  -----------
  Check SW2 when SW1 is 0x90

The starcos_gen_key() correctly checks for SW to be
0x9000, but the starcos_gen_key() does not check for
SW2. The error is not propagated and key generation
works with not allocated values.

Thanks OSS-Fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=68040


  Commit: e9dcfe97de6a6cb8e1bb99b88eefac1889daaa19
      https://github.com/OpenSC/OpenSC/commit/e9dcfe97de6a6cb8e1bb99b88eefac1889daaa19
  Author: Veronika Hanulíková <vha...@re...>
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
    M src/pkcs15init/profile.c
    M src/tests/unittests/check_macro_reference_loop.c

  Log Message:
  -----------
  profile.c: Treat long macro names as error

Limiting the size and not returning an error
leads to infinite recursion if the macro value
is a macro name that is longer than the given
limitation.

Thank OSS-Fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=68061


  Commit: 793e3888920792f55e3079597eeafb486c3f5de8
      https://github.com/OpenSC/OpenSC/commit/793e3888920792f55e3079597eeafb486c3f5de8
  Author: Veronika Hanulíková <vha...@re...>
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
    M src/tests/unittests/check_macro_reference_loop.c

  Log Message:
  -----------
  unittests: Reformat check_macro_reference_loop.c


  Commit: ea4b217825ca4f16c138022f7a75d27bf64c7124
      https://github.com/OpenSC/OpenSC/commit/ea4b217825ca4f16c138022f7a75d27bf64c7124
  Author: Veronika Hanulíková <vha...@re...>
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
    M src/libopensc/iso7816.c
    M src/pkcs15init/profile.c

  Log Message:
  -----------
  Fix formatting


  Commit: 9a484a9d22368d2a0baad05ea6049e4c3d5e8cba
      https://github.com/OpenSC/OpenSC/commit/9a484a9d22368d2a0baad05ea6049e4c3d5e8cba
  Author: Veronika Hanulíková <vha...@re...>
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
    M src/libopensc/pkcs15.c

  Log Message:
  -----------
  pkcs15.c: Fix memory leak

When sc_pkcs15_read_cached_file allocates data pointer
but following sc_select_file fails, the data pointer
is rewritten by another malloc.


Compare: https://github.com/OpenSC/OpenSC/compare/092eea05df97...9a484a9d2236

To unsubscribe from these emails, change your notification settings at https://github.com/OpenSC/OpenSC/settings/notifications