[Opensc-commits] [OpenSC/OpenSC] e8883b: Reimplement removing of PKCS#1 v1.5 padding to be ...

[Veronika H. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: e8883b1f91572c40bab8718f0ba274ab71906490
      https://github.com/OpenSC/OpenSC/commit/e8883b1f91572c40bab8718f0ba274ab71906490
  Author: Veronika Hanulíková <vha...@re...>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M src/common/Makefile.am
    A src/common/constant-time.h
    M src/libopensc/internal.h
    M src/libopensc/padding.c
    M src/libopensc/pkcs15-sec.c
    M src/minidriver/minidriver.c

  Log Message:
  -----------
  Reimplement removing of PKCS#1 v1.5 padding to be time constant


  Commit: bfe0e05f4aa771d6beab4660c06072eb6eedf372
      https://github.com/OpenSC/OpenSC/commit/bfe0e05f4aa771d6beab4660c06072eb6eedf372
  Author: Veronika Hanulíková <vha...@re...>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M src/tests/unittests/Makefile.am
    M src/tests/unittests/Makefile.mak
    A src/tests/unittests/strip_pkcs1_2_padding.c

  Log Message:
  -----------
  Add unit tests for PKCS#1 v1.5 de-padding


  Commit: 2ee8730649e9a0f2ab01597cfba4f72571eed601
      https://github.com/OpenSC/OpenSC/commit/2ee8730649e9a0f2ab01597cfba4f72571eed601
  Author: Veronika Hanulíková <vha...@re...>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M src/libopensc/pkcs15-sec.c

  Log Message:
  -----------
  pkcs15-sec: Remove logging after PKCS#1 v1.5 depadding

To prevent Marvin attack on RSA PKCS#1 v1.5 padding
when logging the return value, signaling the padding error.


  Commit: 0494e46a39ed52a5f81216e88a8a994bb6b7b280
      https://github.com/OpenSC/OpenSC/commit/0494e46a39ed52a5f81216e88a8a994bb6b7b280
  Author: Veronika Hanulíková <vha...@re...>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M src/pkcs11/framework-pkcs15.c

  Log Message:
  -----------
  framework-pkcs15.c: Handle PKCS#1 v1.5 depadding constant-time

In order to not disclose time side-channel when the depadding
fails, do the same operations as for case when depadding ends
with success.


  Commit: 5b5fcc983b37f0d3587f61fd986026647e88c323
      https://github.com/OpenSC/OpenSC/commit/5b5fcc983b37f0d3587f61fd986026647e88c323
  Author: Veronika Hanulíková <vha...@re...>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M src/pkcs11/mechanism.c

  Log Message:
  -----------
  mechanism: Handle PKCS#1 v1.5 depadding constant-time


  Commit: e018f1941bb8630b5ef8cc08b80182d801f4114e
      https://github.com/OpenSC/OpenSC/commit/e018f1941bb8630b5ef8cc08b80182d801f4114e
  Author: Veronika Hanulíková <vha...@re...>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M src/minidriver/minidriver.c

  Log Message:
  -----------
  minidriver: Make CardRSADecrypt constant-time


  Commit: 2d84cec2fc6f5093387d29b0bbc808b24e043b00
      https://github.com/OpenSC/OpenSC/commit/2d84cec2fc6f5093387d29b0bbc808b24e043b00
  Author: Veronika Hanulíková <vha...@re...>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M src/pkcs11/pkcs11-object.c
    M src/pkcs11/sc-pkcs11.h

  Log Message:
  -----------
  pkcs11-object: Remove return value logging

To prevent Marvin attack on RSA PKCS#1 v1.5 padding
when logging the return value, signaling the padding error.


  Commit: b31f82bcebb2a3b53348a1b16f038fce4d3ed9bb
      https://github.com/OpenSC/OpenSC/commit/b31f82bcebb2a3b53348a1b16f038fce4d3ed9bb
  Author: Veronika Hanulíková <vha...@re...>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M src/pkcs11/misc.c

  Log Message:
  -----------
  misc: Compare return value constant-time


Compare: https://github.com/OpenSC/OpenSC/compare/f39c9d2da517...b31f82bcebb2