Menu
▾
▴
[Opensc-commits] [OpenSC/OpenSC] 6414ae: p11test: Do not test weird inputs lengths with ECD...
|
From: Jakub J. <no...@gi...> - 2023-09-21 20:35:34
|
Branch: refs/heads/master Home: https://github.com/OpenSC/OpenSC Commit: 6414aec2df81a1e3323cd9932ce5d7be5b99a5e4 https://github.com/OpenSC/OpenSC/commit/6414aec2df81a1e3323cd9932ce5d7be5b99a5e4 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/tests/p11test/p11test_case_ec_sign.c Log Message: ----------- p11test: Do not test weird inputs lengths with ECDSA mechanism It is usually made to work only with known digest sizes, regardless what the PKCS #11 specification says about that it should work with any input lengths. Commit: 734eaff0d7fc34ac6c18dd1c9cdebcdf6daa4db5 https://github.com/OpenSC/OpenSC/commit/734eaff0d7fc34ac6c18dd1c9cdebcdf6daa4db5 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/libopensc/pkcs15-sc-hsm.c Log Message: ----------- sc-hsm: Public EC keys should have Derive usage This was previously discussed in #2292 and in #2345 Commit: 1c129bb9759ce0f76f6e2c489894f820bd1efe43 https://github.com/OpenSC/OpenSC/commit/1c129bb9759ce0f76f6e2c489894f820bd1efe43 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: A src/tests/p11test/sc-hsm_ref.json Log Message: ----------- Add reference file for testing sc-hsm token Commit: afbccce9490f8ec12ea235c0610ba1c6d1dd6f09 https://github.com/OpenSC/OpenSC/commit/afbccce9490f8ec12ea235c0610ba1c6d1dd6f09 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/tests/p11test/p11test_case_common.c M src/tests/p11test/p11test_case_ec_derive.c M src/tests/p11test/p11test_case_readonly.c M src/tests/p11test/p11test_case_wrap.c Log Message: ----------- p11test: Avoid memory leaks Commit: 84e945d46d24e157ad23aee8a4ff355b472f3846 https://github.com/OpenSC/OpenSC/commit/84e945d46d24e157ad23aee8a4ff355b472f3846 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/libopensc/libopensc.exports M src/libopensc/pkcs15-skey.c M src/libopensc/pkcs15.c M src/libopensc/pkcs15.h M src/pkcs11/framework-pkcs15.c Log Message: ----------- pkcs15: Correctly handle freeying secret keys in memory Commit: 531d782249e32dd538915de7a3cdb2c140b7e777 https://github.com/OpenSC/OpenSC/commit/531d782249e32dd538915de7a3cdb2c140b7e777 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/libopensc/card-piv.c Log Message: ----------- piv: Avoid possible NULL dereference Thanks coverity CID 400265 Commit: 240c737f93ecfa83bf8110212a3da9b2fd4e3731 https://github.com/OpenSC/OpenSC/commit/240c737f93ecfa83bf8110212a3da9b2fd4e3731 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/libopensc/card-piv.c Log Message: ----------- piv: Check return values Thanks coverity CID 400264 Commit: 7236a9ae4ec4a1fe318939371e34d05acb45b089 https://github.com/OpenSC/OpenSC/commit/7236a9ae4ec4a1fe318939371e34d05acb45b089 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/libopensc/card-piv.c Log Message: ----------- piv: Simplify handling of IDsh length This prevents coverity thinking the value can be different from 8. CID 400263 Commit: b87d1f5756a20fc2f8efd6b7ac89b2e475896bf1 https://github.com/OpenSC/OpenSC/commit/b87d1f5756a20fc2f8efd6b7ac89b2e475896bf1 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M .github/test-oseid.sh M .github/workflows/linux.yml M containers/opensc-test-oseid/Containerfile Log Message: ----------- ci: Run oseid with valgrind too The OsEID PR needed for this is available here: https://github.com/popovec/oseid/pull/4 Commit: ebee0cc63896c13741c1181defb911c1aa8c8872 https://github.com/OpenSC/OpenSC/commit/ebee0cc63896c13741c1181defb911c1aa8c8872 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/libopensc/pkcs15-prkey.c Log Message: ----------- Reformat long lines for readability Commit: 600ab32ef062dd959623d1985a3014a200f51018 https://github.com/OpenSC/OpenSC/commit/600ab32ef062dd959623d1985a3014a200f51018 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M .github/setup-linux.sh Log Message: ----------- ci: Install openssl debuginfo to provide useful backtraces Commit: b0a0cec8709ffb47b61a05cf3219a9073fdbe60f https://github.com/OpenSC/OpenSC/commit/b0a0cec8709ffb47b61a05cf3219a9073fdbe60f Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/libopensc/libopensc.exports M src/libopensc/pkcs15-prkey.c M src/libopensc/pkcs15.h M src/tools/pkcs15-init.c Log Message: ----------- pkcs15: Provide erase/free_prkey same as for pubkey The respective functions for public keys and private keys behaved differently, causing a lot of confusion when using them. Fortunately it is not used in many places. Probably fixing also the following oss-fuzz issue: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61965 Commit: eba0eb7d7871415d648e19492f0cbb9bde3f22c7 https://github.com/OpenSC/OpenSC/commit/eba0eb7d7871415d648e19492f0cbb9bde3f22c7 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/libopensc/pkcs15-prkey.c M src/pkcs15init/pkcs15-lib.c M src/tools/pkcs15-init.c Log Message: ----------- pkcs15-init: Fix memory leaks Most of them brought up by valgrind while running the OSeEID tests Commit: a7889764e2863b411ad568da01b05ea70cb7d63f https://github.com/OpenSC/OpenSC/commit/a7889764e2863b411ad568da01b05ea70cb7d63f Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/tools/pkcs11-tool.c Log Message: ----------- pkcs11-tool: Avoid memory leaks Commit: 354246828079544eef8592405e426d095328f0fa https://github.com/OpenSC/OpenSC/commit/354246828079544eef8592405e426d095328f0fa Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/pkcs11/framework-pkcs15.c Log Message: ----------- pkcs11: Avoid use of uninitialized variables while doing symmetric deciphering Commit: a979f23d64c6a00d2c6f6e00957d86b24d095b6b https://github.com/OpenSC/OpenSC/commit/a979f23d64c6a00d2c6f6e00957d86b24d095b6b Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M .github/test-oseid.sh Log Message: ----------- ci: Run p11test anyway for oseid at least to capture memory issues Commit: e440120cca9f42444477635a4c2c70e94fac8fdb https://github.com/OpenSC/OpenSC/commit/e440120cca9f42444477635a4c2c70e94fac8fdb Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M .gitignore Log Message: ----------- .gitignore: Add new generated files Commit: 55edcb16feb94c23e241b9ed2cfe3db5941203d7 https://github.com/OpenSC/OpenSC/commit/55edcb16feb94c23e241b9ed2cfe3db5941203d7 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/tests/p11test/p11test_case_ec_sign.c M src/tests/p11test/p11test_case_readonly.c Log Message: ----------- p11test: Skip derive mechanisms while running signature tests Commit: 9da052df69134393f036c8065e8a34e101451176 https://github.com/OpenSC/OpenSC/commit/9da052df69134393f036c8065e8a34e101451176 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/tests/p11test/p11test_case_pss_oaep.c Log Message: ----------- p11test: Make the title more self-describing Commit: 3bfc6b910799a80bb4eefc71da7cc985cd60c9ce https://github.com/OpenSC/OpenSC/commit/3bfc6b910799a80bb4eefc71da7cc985cd60c9ce Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M .github/setup-valgrind.sh Log Message: ----------- ci: Keep valgrind quite to avoid noise Commit: cbddca6d170ef5c33b8ff9a0f52549b4ec4ab86e https://github.com/OpenSC/OpenSC/commit/cbddca6d170ef5c33b8ff9a0f52549b4ec4ab86e Author: Frank Morgner <fra...@gm...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/pkcs11/framework-pkcs15.c Log Message: ----------- pkcs11: clean up secret key information Commit: d1acf3bab9036107ac19af871c548d6f47a3a83d https://github.com/OpenSC/OpenSC/commit/d1acf3bab9036107ac19af871c548d6f47a3a83d Author: Frank Morgner <fra...@gm...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/libopensc/pkcs15-prkey.c Log Message: ----------- erase private key data on clean up Commit: 0875c69295ef28b45fb682b37cede58fc36b7a1a https://github.com/OpenSC/OpenSC/commit/0875c69295ef28b45fb682b37cede58fc36b7a1a Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/libopensc/pkcs15-cache.c Log Message: ----------- pkcs15-cache: Avoid fd leaks and check return values CID 401725 CID 401726 Thanks coverity Commit: ed44af2724b24dc9fbd8b25eb5dbe6cb7aad8f16 https://github.com/OpenSC/OpenSC/commit/ed44af2724b24dc9fbd8b25eb5dbe6cb7aad8f16 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/pkcs11/framework-pkcs15.c Log Message: ----------- pkcs11: Avoid memory leak session secret keys Normally, any keys are added to the pkcs15 directory structure, which is tracked by the pkcs15 layer, but this does not happen for session objects (see sc_pkcs15init_store_secret_key()) so when clearing the key from the pkcs11 layer, we need to check if this key is session key and if so, free it. We can not free it for non-session keys as this would cause double-free as the pkcs15 layer attempts to free these too through the same reference. Commit: 1634adab29757ecbb5b9b5635e0a66ef92fa56ce https://github.com/OpenSC/OpenSC/commit/1634adab29757ecbb5b9b5635e0a66ef92fa56ce Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/libopensc/card-oberthur.c Log Message: ----------- oberthur: Avoid memory leak Thanks oss-fuzz https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61976 Commit: 41d61da8481582e12710b5858f8b635e0a71ab5e https://github.com/OpenSC/OpenSC/commit/41d61da8481582e12710b5858f8b635e0a71ab5e Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M src/pkcs15init/pkcs15-oberthur.c Log Message: ----------- oberthur: Avoid buffer overflow Thanks oss-fuzz https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=60650 Commit: f7dc16401cef84cdfde212de38cb6faa125430b9 https://github.com/OpenSC/OpenSC/commit/f7dc16401cef84cdfde212de38cb6faa125430b9 Author: Jakub Jelen <jj...@re...> Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M .github/setup-linux.sh M .github/workflows/linux.yml Log Message: ----------- ci: Do not install debug symbols if not needed as it sounds flaky and time consuming Compare: https://github.com/OpenSC/OpenSC/compare/188d0fa6769c...f7dc16401cef |
