[Opensc-commits] [OpenSC/OpenSC] dd712f: coolkey: Use packed structure to fix coverity warning

[Jakub J. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: dd712f529be0064c7326683876c8d89b6080ddcb
      https://github.com/OpenSC/OpenSC/commit/dd712f529be0064c7326683876c8d89b6080ddcb
  Author: Jakub Jelen <jj...@re...>
  Date:   2023-07-17 (Mon, 17 Jul 2023)

  Changed paths:
    M src/libopensc/card-coolkey.c

  Log Message:
  -----------
  coolkey: Use packed structure to fix coverity warning

The way how data is loaded into the structures and usage of offsetof
depends on the structure being packed. This is compiler-dependent.

Thanks coverity.

CID 353967

Fixes #2811


  Commit: 075d482c07b581e11ea5165cff5c973dab8a5808
      https://github.com/OpenSC/OpenSC/commit/075d482c07b581e11ea5165cff5c973dab8a5808
  Author: Jakub Jelen <jj...@re...>
  Date:   2023-07-17 (Mon, 17 Jul 2023)

  Changed paths:
    M src/libopensc/apdu.c

  Log Message:
  -----------
  apdu: Avoid setting value without reading (and misplaced comment)

The Lc is the length of the data, which can not be null with
chainging as we try to pass more data. The comment corresponds
to the Le or resplen fields.

Thanks coverity

CID 384376


  Commit: 4c8221ca9120d45e4605114d7b28da5339ecdbf5
      https://github.com/OpenSC/OpenSC/commit/4c8221ca9120d45e4605114d7b28da5339ecdbf5
  Author: Jakub Jelen <jj...@re...>
  Date:   2023-07-17 (Mon, 17 Jul 2023)

  Changed paths:
    M src/tests/p11test/p11test_case_common.c

  Log Message:
  -----------
  p11test: Fix copy&paste error while handling secret key attributes

Thanks coverity

CID 374845


  Commit: 09ba9cf370a4e3defbb049337f1ee6defdd3cbc8
      https://github.com/OpenSC/OpenSC/commit/09ba9cf370a4e3defbb049337f1ee6defdd3cbc8
  Author: Jakub Jelen <jj...@re...>
  Date:   2023-07-17 (Mon, 17 Jul 2023)

  Changed paths:
    M src/tools/opensc-explorer.c

  Log Message:
  -----------
  tools: Avoid using uninitialized buffers

When sc_lock would return (for some reason) positive integer,
we would end up using uninitilized buffer. Make sure it is initialized
and make sure we fail early if the lock fails.

Thanks coverity

CID 367545


Compare: https://github.com/OpenSC/OpenSC/compare/b17d4a4dfb02...09ba9cf370a4