Menu
▾
▴
[Opensc-commits] [OpenSC/OpenSC] ea6273: .editorconfig: Use tabs in shell scripts too
|
From: Jakub J. <no...@gi...> - 2023-05-31 11:58:55
|
Branch: refs/heads/master Home: https://github.com/OpenSC/OpenSC Commit: ea6273f4b9fb0082857f6dfd54f30ba00ba81d1d https://github.com/OpenSC/OpenSC/commit/ea6273f4b9fb0082857f6dfd54f30ba00ba81d1d Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M .editorconfig Log Message: ----------- .editorconfig: Use tabs in shell scripts too Commit: e0f737f1dcbb7cb643afc0c1d6ab8f6cc002b7f0 https://github.com/OpenSC/OpenSC/commit/e0f737f1dcbb7cb643afc0c1d6ab8f6cc002b7f0 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/libopensc/card-westcos.c M src/pkcs11/framework-pkcs15.c M src/pkcs11/pkcs11-global.c M src/pkcs15init/pkcs15-lib.c Log Message: ----------- Remove trainling whitespace Commit: b53977a5274e86c6a58b5939367b8496a2ec84f9 https://github.com/OpenSC/OpenSC/commit/b53977a5274e86c6a58b5939367b8496a2ec84f9 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M .github/test-piv.sh Log Message: ----------- tests: Extract the PIN to separate variable Commit: 352aba0e3794c46a98232a50572f285106f5d8a0 https://github.com/OpenSC/OpenSC/commit/352aba0e3794c46a98232a50572f285106f5d8a0 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M .github/test-piv.sh Log Message: ----------- tests: Use separate file for the second cert Commit: c6d461c2d19ae07adb1a2604384bf0fccb9e7a4a https://github.com/OpenSC/OpenSC/commit/c6d461c2d19ae07adb1a2604384bf0fccb9e7a4a Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M .github/setup-vsmartcard.sh M .github/test-cac.sh M .github/test-gidsapplet.sh M .github/test-openpgp.sh M .github/test-piv.sh Log Message: ----------- ci: Split code download and build This is useful for running the CI locally in containers, which makes things much faster than it would need to download, build and install all the test tools. Commit: d42d10c88e7e3456f19fc083e30543958e3cb2f8 https://github.com/OpenSC/OpenSC/commit/d42d10c88e7e3456f19fc083e30543958e3cb2f8 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/tools/pkcs11-tool.c Log Message: ----------- pkcs11-tool: Avoid memory leaks Commit: 5241ce853403da775e37ecb36fb6a968001ef115 https://github.com/OpenSC/OpenSC/commit/5241ce853403da775e37ecb36fb6a968001ef115 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/tools/pkcs11-tool.c Log Message: ----------- pkcs11-tool: Do not compare uninitialized memory if GetRandom fails Commit: afae9fcc2f4ead520fdb2de4b768e260b7c97a2b https://github.com/OpenSC/OpenSC/commit/afae9fcc2f4ead520fdb2de4b768e260b7c97a2b Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M containers/opensc-test-cac/Containerfile A containers/opensc-test-gidsapplet/Containerfile M containers/opensc-test-piv/Containerfile Log Message: ----------- containers: Sync with CI Commit: e1d7e967b550b3e66ceacc0ca7decc3fd6cb8452 https://github.com/OpenSC/OpenSC/commit/e1d7e967b550b3e66ceacc0ca7decc3fd6cb8452 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/pkcs15init/pkcs15-lib.c Log Message: ----------- pkcs15init: Remove duplicate cleanup Commit: 2b2bf39feb8ad899364b563e7c588efbca68f419 https://github.com/OpenSC/OpenSC/commit/2b2bf39feb8ad899364b563e7c588efbca68f419 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/tests/p11test/p11test_case_common.c Log Message: ----------- p11test: Avoid memory leaks deteted by valgrind Commit: b46d387019dbe8ea658f422dcb87c61355713d16 https://github.com/OpenSC/OpenSC/commit/b46d387019dbe8ea658f422dcb87c61355713d16 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/pkcs15init/pkcs15-lib.c Log Message: ----------- pkcs15init: Revise cleanup after keygen and storing keys There were needless assignment immediately rewritten with copy function, some of the structures were not copied and not freed from the target contexts and similar issues. Commit: fbc8bd114a549b347255391d26259207b66d1c6b https://github.com/OpenSC/OpenSC/commit/fbc8bd114a549b347255391d26259207b66d1c6b Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/pkcs11/framework-pkcs15.c Log Message: ----------- pkcs11: Free memory after storing keys Commit: 79efc06fe2aff9313fa587c09190109aaeb521b5 https://github.com/OpenSC/OpenSC/commit/79efc06fe2aff9313fa587c09190109aaeb521b5 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/pkcs15init/pkcs15-isoApplet.c Log Message: ----------- isoapplet: Do not leak memory if params were allocated already Commit: d5fbee7a7b502c796fa89da61c87a0dff1ad229a https://github.com/OpenSC/OpenSC/commit/d5fbee7a7b502c796fa89da61c87a0dff1ad229a Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/common/Makefile.am M src/libopensc/Makefile.am M src/pkcs11/Makefile.am Log Message: ----------- Mark clang-tidy warnings errors Commit: b8a0c6dd10308ddcd4d878d1a9029fe2d93bd3da https://github.com/OpenSC/OpenSC/commit/b8a0c6dd10308ddcd4d878d1a9029fe2d93bd3da Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/libopensc/iso7816.c Log Message: ----------- iso7816: Return errors on failure Reported by clang-tidy as set-but never read variable: /home/runner/work/OpenSC/OpenSC/src/libopensc/iso7816.c:366:2: warning: Value stored to 'r' is never read [clang-analyzer-deadcode.DeadStores] r = count; ^ /home/runner/work/OpenSC/OpenSC/src/libopensc/iso7816.c:366:2: note: Value stored to 'r' is never read Commit: 478d5911e56352e2a3ac69693da8355b284c7a66 https://github.com/OpenSC/OpenSC/commit/478d5911e56352e2a3ac69693da8355b284c7a66 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/libopensc/card-westcos.c Log Message: ----------- westcos: Avoid memory leak Accidentally introduced with 264b23aff5b01acebe9627dff4468fa42eb5a825, reported by clang-tidy /home/runner/work/OpenSC/OpenSC/src/libopensc/card-westcos.c:664:7: warning: Although the value stored to 'cctx' is used in the enclosing expression, the value is never actually read from 'cctx' [clang-analyzer-deadcode.DeadStores] if ((cctx = EVP_CIPHER_CTX_new()) == NULL) ^ /home/runner/work/OpenSC/OpenSC/src/libopensc/card-westcos.c:664:7: note: Although the value stored to 'cctx' is used in the enclosing expression, the value is never actually read from 'cctx' Commit: 18b63d279aa65133429b2b5024f4eddf6c87e42c https://github.com/OpenSC/OpenSC/commit/18b63d279aa65133429b2b5024f4eddf6c87e42c Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/libopensc/card-sc-hsm.c Log Message: ----------- card-sc-hsm: Remove dead code Reported by clang-tidy: /home/runner/work/OpenSC/OpenSC/src/libopensc/card-sc-hsm.c:854:3: warning: Value stored to 'len' is never read [clang-analyzer-deadcode.DeadStores] len = 0; ^ /home/runner/work/OpenSC/OpenSC/src/libopensc/card-sc-hsm.c:854:3: note: Value stored to 'len' is never read Commit: f4891aabd169a2c72ea97110d46f093570d48679 https://github.com/OpenSC/OpenSC/commit/f4891aabd169a2c72ea97110d46f093570d48679 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/tools/netkey-tool.c Log Message: ----------- tools: Avoid set-but-not-used variable in netkey-tool Commit: 1952e2e2b249c109049c050c141001fdceda84e1 https://github.com/OpenSC/OpenSC/commit/1952e2e2b249c109049c050c141001fdceda84e1 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M .github/setup-linux.sh Log Message: ----------- ci: Fail early if we can not set up libressl Commit: 6a1ff88d5c45e0b927922928cd947a95caccd4ed https://github.com/OpenSC/OpenSC/commit/6a1ff88d5c45e0b927922928cd947a95caccd4ed Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M tests/common.sh M tests/test-pkcs11-tool-sign-verify.sh Log Message: ----------- tests: Fix the secret key test that never worked Commit: 28a1bf19833d95aa759b8f8984edbea6234fd10c https://github.com/OpenSC/OpenSC/commit/28a1bf19833d95aa759b8f8984edbea6234fd10c Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/tests/unittests/asn1.c M src/tests/unittests/compression.c M src/tests/unittests/decode_ecdsa_signature.c M src/tests/unittests/pkcs15-emulator-filter.c Log Message: ----------- unittests: Avoid memory leaks or invalid memory access Commit: fbc4ebbc8ebdb5f15663576e33b97f7588a90643 https://github.com/OpenSC/OpenSC/commit/fbc4ebbc8ebdb5f15663576e33b97f7588a90643 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M .github/setup-linux.sh Log Message: ----------- ci: Try to address another breakage of 32b images Commit: 2b4958e49e00b064ad91475a55897a3d63033a1d https://github.com/OpenSC/OpenSC/commit/2b4958e49e00b064ad91475a55897a3d63033a1d Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: A m4/ax_valgrind_check.m4 Log Message: ----------- m4: Use up-to-date valgrind from current autoconf-archive Commit: c80d63a3d080ffabfba069b4a9114a3c7f2afae3 https://github.com/OpenSC/OpenSC/commit/c80d63a3d080ffabfba069b4a9114a3c7f2afae3 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M .github/workflows/linux.yml Log Message: ----------- ci: Upload also unit tests results Commit: 3cca65baa152ce327970e5892417f65a09a464a8 https://github.com/OpenSC/OpenSC/commit/3cca65baa152ce327970e5892417f65a09a464a8 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/tests/p11test/p11test_case_pss_oaep.c Log Message: ----------- p11test: Free message on exit path Commit: ef56df67eee3f84ee91d0b283a6206515c88a5bb https://github.com/OpenSC/OpenSC/commit/ef56df67eee3f84ee91d0b283a6206515c88a5bb Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/libopensc/card-openpgp.c M src/tools/openpgp-tool.c Log Message: ----------- openpgp: Free allocated memory Commit: e8fba322a2f4d06ec5c74fe80f9e2b0e9fdefec6 https://github.com/OpenSC/OpenSC/commit/e8fba322a2f4d06ec5c74fe80f9e2b0e9fdefec6 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- openpgp: Fix fingerprint calculation fixes https://github.com/OpenSC/OpenSC/issues/2775 Commit: 6f4c270060f556ff01ebc53fac4e6d4ab5249c91 https://github.com/OpenSC/OpenSC/commit/6f4c270060f556ff01ebc53fac4e6d4ab5249c91 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/libopensc/card-isoApplet.c Log Message: ----------- isoapplet: Fix RSA-PSS calculation when the data does not contain digestinfo This lead to using of uninitialized memory (tmp array) when talking to the pcsc and inevitable failure to verify the signature throughout the tests. Commit: 9a8a442d482865f88e70dd3d7b9b916fdfc297ed https://github.com/OpenSC/OpenSC/commit/9a8a442d482865f88e70dd3d7b9b916fdfc297ed Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/tests/p11test/isoapplet_ref_v1.json Log Message: ----------- tests: Update isoapplet v1 reference p11test log Commit: 891f10e49de1a5ee038b1cb2fb59dce40429e6c2 https://github.com/OpenSC/OpenSC/commit/891f10e49de1a5ee038b1cb2fb59dce40429e6c2 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/libopensc/pkcs15.h M src/pkcs15init/pkcs15-openpgp.c Log Message: ----------- openpgp: Fix modulus length calculation in pkc15init layer Commit: f38ea19d33f5799232795d6d9b471287b782c140 https://github.com/OpenSC/OpenSC/commit/f38ea19d33f5799232795d6d9b471287b782c140 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- openpgp: Avoid leaking file structure Commit: bc114501faacfc69eaa98b789463d180a1b71da7 https://github.com/OpenSC/OpenSC/commit/bc114501faacfc69eaa98b789463d180a1b71da7 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M .github/build.sh A .github/dump-logs.sh M .github/setup-linux.sh A .github/setup-valgrind.sh M .github/test-cac.sh M .github/test-gidsapplet.sh M .github/test-isoapplet.sh M .github/test-openpgp.sh M .github/test-piv.sh M .github/workflows/linux.yml M configure.ac M src/tests/unittests/Makefile.am M tests/Makefile.am M tests/common.sh Log Message: ----------- tests: Support running under valgrind both tests executed during `make check` as well as the integration tests ran from the github CI with java card simulator or other software implementations. Commit: 481951b90b042b43fb5bd92cd3cd8d0f7e200b89 https://github.com/OpenSC/OpenSC/commit/481951b90b042b43fb5bd92cd3cd8d0f7e200b89 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M tests/common.sh Log Message: ----------- tests: Properly propagate the VALGRIND env variable to the shell tests The valgrind macros set the VALGRIND variable without any arguments, which prevents it from failing if some issue is detected. Commit: 63d4bd3d3900682c8d2511e259abec63ce904895 https://github.com/OpenSC/OpenSC/commit/63d4bd3d3900682c8d2511e259abec63ce904895 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/tools/pkcs11-tool.c Log Message: ----------- pkcs11-tool: Avoid dereferencing freed members when reading public keys Commit: e53f61ff145ea9de49c0858c0067078da68d6373 https://github.com/OpenSC/OpenSC/commit/e53f61ff145ea9de49c0858c0067078da68d6373 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M tests/common.sh M tests/test-pkcs11-tool-import.sh M tests/test-pkcs11-tool-sign-verify.sh M tests/test-pkcs11-tool-test.sh Log Message: ----------- tests: Check exit codes of helper functions Commit: 646d8f5d5f02c7e472a3390d9b24177b19a556c7 https://github.com/OpenSC/OpenSC/commit/646d8f5d5f02c7e472a3390d9b24177b19a556c7 Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/tests/p11test/p11test_case_common.c Log Message: ----------- fixup! p11test: Avoid memory leaks deteted by valgrind Commit: 9f7e83fed024a18333bd4e7a31286cec104bb0bf https://github.com/OpenSC/OpenSC/commit/9f7e83fed024a18333bd4e7a31286cec104bb0bf Author: Jakub Jelen <jj...@re...> Date: 2023-05-31 (Wed, 31 May 2023) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- fixup! openpgp: Free allocated memory Compare: https://github.com/OpenSC/OpenSC/compare/81944d152920...9f7e83fed024 |
