[Opensc-commits] [OpenSC/OpenSC] fd474f: log errors for sc_unlock

[Frank M. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: fd474fb7a1de7494c513b4b5df8bd6b135e79cea
      https://github.com/OpenSC/OpenSC/commit/fd474fb7a1de7494c513b4b5df8bd6b135e79cea
  Author: Frank Morgner <fra...@gm...>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M src/libopensc/card.c

  Log Message:
  -----------
  log errors for sc_unlock


  Commit: b9d5ac45f111910fc9e32600ce26b58350c81790
      https://github.com/OpenSC/OpenSC/commit/b9d5ac45f111910fc9e32600ce26b58350c81790
  Author: Frank Morgner <fra...@gm...>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M src/pkcs11/pkcs11-global.c

  Log Message:
  -----------
  pkcs#11: fixed multiple race conditions during C_Initialize


  Commit: d449feeda6b3d8ec27a184417d9b5d1ba73df6d7
      https://github.com/OpenSC/OpenSC/commit/d449feeda6b3d8ec27a184417d9b5d1ba73df6d7
  Author: Frank Morgner <fra...@gm...>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M src/libopensc/card.c

  Log Message:
  -----------
  fixed race conditions in sc_lock()

card->mutex is used to protect card->lock_count, so let's limit the
scope of the mutex to where the lock_count is used.

First and foremost, this fixes
https://github.com/OpenSC/OpenSC/issues/2707, which is caused by PIV's
failing card_reader_lock_obtained, which would have caused sc_lock to
change lock_count while *not* locking the mutex, which creates a race
condition with other threads using and modifying lock_count.

Secondly, this fixes a possible dead lock when sc_lock is used inside
the card's card->sm_ctx.ops.open, which previously would be called in
sc_lock when the mutex was locked.


  Commit: cf753d53b07b28f2a89ac51be29c42519afec143
      https://github.com/OpenSC/OpenSC/commit/cf753d53b07b28f2a89ac51be29c42519afec143
  Author: Frank Morgner <fra...@gm...>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  pkcs11-tool: allow interactive thread tests

Threads can now run the same tests as if pkcs11-tool was started with `--test`, e.g.
```
pkcs11-tool --use-locking --pin=123456 --test-threads LT  --test-threads LT
```


  Commit: ee7fb476d6c72fc53cf6d844be24a4f42a4e9cb5
      https://github.com/OpenSC/OpenSC/commit/ee7fb476d6c72fc53cf6d844be24a4f42a4e9cb5
  Author: Frank Morgner <fra...@gm...>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M src/pkcs11/framework-pkcs15.c

  Log Message:
  -----------
  pkcs#11: fixed race condition in C_GetTokenInfo


  Commit: 22aa65ca51674f0c2921aa4d8a2b5d9e4ff549a8
      https://github.com/OpenSC/OpenSC/commit/22aa65ca51674f0c2921aa4d8a2b5d9e4ff549a8
  Author: Frank Morgner <fra...@gm...>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M src/pkcs11/pkcs11-object.c

  Log Message:
  -----------
  pkcs#11: fixed race condition in C_GenerateRandom


  Commit: 7b1729a1bc69f3139500246d807098d43994cbc4
      https://github.com/OpenSC/OpenSC/commit/7b1729a1bc69f3139500246d807098d43994cbc4
  Author: Frank Morgner <fra...@gm...>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  pkcs11-tool: fixed race condition for loading openssl's legacy provider


  Commit: aa394f2576adf9950d98f4994e7680574139854b
      https://github.com/OpenSC/OpenSC/commit/aa394f2576adf9950d98f4994e7680574139854b
  Author: Frank Morgner <fra...@gm...>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  pkcs11-tool: fixed race condition in --test-threads


Compare: https://github.com/OpenSC/OpenSC/compare/5499acb3767e...aa394f2576ad