Re: [Opensc-devel] Various patches for pkcs11-tool

[Jakub J. <jj...@re...>]

On 11/14/22 11:10, Alexandre Gonzalo via Opensc-devel wrote:
> Hi all,
> 
> I recently had time to test the first release candidate and I tried the 
> HMAC sign/verify now available for the pkcs11-tool.
> I had several minor issues that I fixed with the following attached patches:
> -0005-feat-pkcs11-tool-add-CKM_SHA3_XXX_HMAC-mechanisms.patch
> -0006-feat-pkcs11-tool-usage-sign-is-also-for-secret-keys.patch
> -0007-feat-pkcs11-tool-add-MF_GENERIC_HMAC_FLAGS-for-CKM_M.patch
> 
> If you want, I can create a new PR with these fixes.
> 
> I also have two other patches for new features:
>   - 0002-feat-pkcs11-tool-print-CKA_UNIQUE_ID-value-for-keys-.patch
>   - 0003-feat-pkcs11-tool-add-new-undestroyable-option-to-spe.patch
> 
> Please, let me know if you want them for the future releases.

Hi,
thank you for testing, the email and patches!

All of them look useful on the first sight, so please, open a new PR on 
https://github.com/OpenSC/OpenSC/ -- it makes it easier for us to review 
the changes and run some sanity checks on them, if this is not a problem 
for you.

Regards,
-- 
Jakub Jelen
Crypto Team, Security Engineering
Red Hat, Inc.