[Opensc-commits] [OpenSC/OpenSC] 305cee: rewrite to fix coverity warning (false positive)

[Frank M. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 305cee54d1ede6e3e8fd62b9efb21d2cf92a8d3f
      https://github.com/OpenSC/OpenSC/commit/305cee54d1ede6e3e8fd62b9efb21d2cf92a8d3f
  Author: Frank Morgner <fra...@gm...>
  Date:   2022-03-01 (Tue, 01 Mar 2022)

  Changed paths:
    M src/tools/pkcs15-tool.c

  Log Message:
  -----------
  rewrite to fix coverity warning (false positive)

fixes coverity 376511 String not null terminated


  Commit: 17af54a0a426e2963fb6eb2b8928be6676ab5337
      https://github.com/OpenSC/OpenSC/commit/17af54a0a426e2963fb6eb2b8928be6676ab5337
  Author: Frank Morgner <fra...@gm...>
  Date:   2022-03-01 (Tue, 01 Mar 2022)

  Changed paths:
    M src/tools/cryptoflex-tool.c

  Log Message:
  -----------
  cryptoflex-tool: fixed returning value

regression of 08ab72d50

fixes coverity CID 374952 (#1 of 1): Parse warning (PW.PARAM_SET_BUT_NOT_USED)


  Commit: 3a8263f92bbc98c274f2893281a06f031ba27b06
      https://github.com/OpenSC/OpenSC/commit/3a8263f92bbc98c274f2893281a06f031ba27b06
  Author: Frank Morgner <fra...@gm...>
  Date:   2022-03-01 (Tue, 01 Mar 2022)

  Changed paths:
    M src/pkcs15init/pkcs15-westcos.c

  Log Message:
  -----------
  fixed coverity CID 374950 (#1 of 1): Logically dead code (DEADCODE)

regression of f214e655b


  Commit: cacc881ed8fe612a9d60b862edb27070d4c6ba94
      https://github.com/OpenSC/OpenSC/commit/cacc881ed8fe612a9d60b862edb27070d4c6ba94
  Author: Frank Morgner <fra...@gm...>
  Date:   2022-03-01 (Tue, 01 Mar 2022)

  Changed paths:
    M src/libopensc/card-epass2003.c

  Log Message:
  -----------
  fixed CID 374849 (#1 of 1): Unchecked return value (CHECKED_RETURN)


  Commit: a06abbf5a767a97a9627d5f786dd0d404c6cb8a0
      https://github.com/OpenSC/OpenSC/commit/a06abbf5a767a97a9627d5f786dd0d404c6cb8a0
  Author: Frank Morgner <fra...@gm...>
  Date:   2022-03-01 (Tue, 01 Mar 2022)

  Changed paths:
    M src/libopensc/reader-pcsc.c

  Log Message:
  -----------
  pcsc: don't use a shorthand array of interpreting tlv data

fixes CID 367426 (#1 of 1): Out-of-bounds access (ARRAY_VS_SINGLETON)

note that structure padding could still happen inside
PCSC_TLV_STRUCTURE. However, we're keeping consistency with libccid,
which, too, doesn't use `__attribute__((packed))` for this


Compare: https://github.com/OpenSC/OpenSC/compare/8f7c23bfaa30...a06abbf5a767