[Opensc-commits] [OpenSC/OpenSC] 9ac929: OpenPGP 3.4+: Get list of supported algorithms fro...

[Yar <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 9ac92952b6dd062f95fd334d89663bd664dd8644
      https://github.com/OpenSC/OpenSC/commit/9ac92952b6dd062f95fd334d89663bd664dd8644
  Author: Yaroslav Isakov <yar...@gm...>
  Date:   2021-12-04 (Sat, 04 Dec 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP 3.4+: Get list of supported algorithms from Algorithm Information

OpenPGP Card 3.4+ supports getting list of algos from the new Algoritm Information DO
https://gnupg.org/ftp/specs/OpenPGP-smart-card-application-3.4.pdf, 4.4.3.11
If at least one algo is in this list, use it, and ignore hardcoded.

Tested on Yubikey 5 NFC with FW 5.2.4. Handled few problems with Yubikey not
following the spec.

Also, fixed problem with algorithm find, which will return EC algorithm with the same
key size, even if curve is not the same.


  Commit: bf4a3aaf945b62e2fa1298aec0f5c815a1630c54
      https://github.com/OpenSC/OpenSC/commit/bf4a3aaf945b62e2fa1298aec0f5c815a1630c54
  Author: Yaroslav Isakov <yar...@gm...>
  Date:   2021-12-04 (Sat, 04 Dec 2021)

  Changed paths:
    M src/libopensc/card.c

  Log Message:
  -----------
  Fix find for EC algos returning wrong algo

If we're finding EC algo, and curve is not matched, another algo
with the same key length shoud not be returned.


  Commit: e11a78f9104311fc8e6df873510152fe66d37a5f
      https://github.com/OpenSC/OpenSC/commit/e11a78f9104311fc8e6df873510152fe66d37a5f
  Author: Yaroslav Isakov <yar...@gm...>
  Date:   2021-12-04 (Sat, 04 Dec 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  Some changes in DO FA handling:
- Now it's checked independent from DO 6E
- If no algos can be parsed from DO FA, code will fallback to other ways
- Indentation fixes


  Commit: 21347deb3d1f1ac6bca355211c95bc4f9697afbf
      https://github.com/OpenSC/OpenSC/commit/21347deb3d1f1ac6bca355211c95bc4f9697afbf
  Author: Yaroslav Isakov <yar...@gm...>
  Date:   2021-12-04 (Sat, 04 Dec 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  Fix pass of handling_algos if DO 6E is not available


  Commit: d4b589044946e17eaab3c0d01187fa98a0295cc8
      https://github.com/OpenSC/OpenSC/commit/d4b589044946e17eaab3c0d01187fa98a0295cc8
  Author: Yaroslav Isakov <yar...@gm...>
  Date:   2021-12-04 (Sat, 04 Dec 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  Fix error check in pgp_enumerate_blob


  Commit: ede23473b49958af4d5a2d1a8a1eb72aaf5884a2
      https://github.com/OpenSC/OpenSC/commit/ede23473b49958af4d5a2d1a8a1eb72aaf5884a2
  Author: Yaroslav Isakov <yar...@gm...>
  Date:   2021-12-04 (Sat, 04 Dec 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c
    M src/pkcs11/mechanism.c
    M src/pkcs11/openssl.c
    M src/pkcs11/pkcs11-object.c
    M src/pkcs11/sc-pkcs11.h

  Log Message:
  -----------
  Fixed returning multiple mechanisms

After parsing DO FA, algorithm info could have both X25519 and
older EC curves. This leads to register of two mechanisms with same type,
CKM_ECDH1_DERIVE, but different key types. This could lead to a situation,
that C_DeriveKey will throw an error, while user is trying to derive
using X25519 key. This commit fixes this, to have a list of key types,
and registering the second mechanism will just add key type to list in
the existing mechanism, and updates it's mech_info.


  Commit: 2cc7b10b80081171854cbf9183e012a0c1a1a5e3
      https://github.com/OpenSC/OpenSC/commit/2cc7b10b80081171854cbf9183e012a0c1a1a5e3
  Author: Yaroslav Isakov <yar...@gm...>
  Date:   2021-12-04 (Sat, 04 Dec 2021)

  Changed paths:
    M src/pkcs11/mechanism.c

  Log Message:
  -----------
  Fix comments from review


Compare: https://github.com/OpenSC/OpenSC/compare/33a22c8b1d2f...2cc7b10b8008